RF: Replace distutils LooseVersion with looseversion - #6839
Merged
Conversation
|
Code Climate has analyzed commit 4e3004c and detected 0 issues on this pull request. View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## master #6839 +/- ##
==========================================
+ Coverage 90.25% 91.20% +0.95%
==========================================
Files 354 354
Lines 46058 46058
==========================================
+ Hits 41568 42008 +440
+ Misses 4490 4050 -440
Continue to review full report at Codecov.
|
yarikoptic
approved these changes
Jul 15, 2022
yarikoptic
left a comment
yarikoptic
left a comment
Member
There was a problem hiding this comment.
Unavoidable. Thank you @effigies
Member
|
There is no rush but also no objections, so let's just proceed! |
Collaborator
|
PR released in |
adswa
added a commit
to adswa/datalad
that referenced
this pull request
Mar 13, 2023
Originally, datalad#6839 replaced usage of distutils with Looseversion as a fix for datalad#6307. Somehow, this one isolated import of distutils seems to have made it back now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6307
Followed the convention of stdlib -> dependency -> currentpackage imports, but since there weren't dependency imports in these two files, I'm not positive that you follow this convention. LMK if I should change anything.
Changelog
🏠 Internal
looseversion.LooseVersionas drop-in replacement fordistutils.version.LooseVersion