BF: Make create's check for procedures work with several again #6841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A comment in code review accidentally changed the return type of an internal run_procdure --discover call within create from list to generator: datalad#6457 (comment) When several procedures were given to create at once (described in datalad#6840), the loop over the generator was repeated for each procedure, and due to chance, procedure discovery sometimes failed when the generator was depleted at the second for loop iteration. This change reverts this and changes the return type back to 'list'. Fixes datalad#6840.
Codecov Report
@@ Coverage Diff @@
## maint #6841 +/- ##
==========================================
+ Coverage 90.27% 91.21% +0.94%
==========================================
Files 354 354
Lines 46079 46065 -14
==========================================
+ Hits 41597 42019 +422
+ Misses 4482 4046 -436
Continue to review full report at Codecov.
|
mslw
approved these changes
Jul 15, 2022
|
Travis test fails on Python 3.10 only (reasons unrelated to this change), so given that there is another approval I believe I can click merge immediately. |
yarikoptic
added a commit
to yarikoptic/datalad
that referenced
this pull request
Jul 15, 2022
not sure why I chose 0624 whenever I talk about some state after 10.20220525 in https://git-annex.branchable.com/bugs/regression__58___annex_add_of_moved_file_errors_out/ . This lead to recent fail in datalad#6841 not sure how it worked before since we should have been installing that newer version for a while already. May be something changed in conda so it started to install earlier nodep version instead of depall
submitted attempt to fix at least one issue among 2 at #6842 |
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A comment in code review accidentally changed the return type of
an internal
run_procdure --discovercall withincreatefromlistto
generator: #6457 (comment)When several procedures were given to
createat once (described in#6840), the loop over the generator was repeated for each procedure,
and due to chance, procedure discovery sometimes failed when the
generator was depleted at the second for loop iteration.
This change reverts this and changes the return type back to 'list'.
Fixes #6840.
Changelog
🐛 Bug Fixes