Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF(TST): do proceed to proper test for error being caught for recent git-annex on windows with symlinks #6850

Merged
merged 1 commit into from
Jul 16, 2022

Conversation

yarikoptic
Copy link
Member

Closes #6849

@yarikoptic yarikoptic added platform-windows Issue concerned with Windows semver-tests Changes only affect tests, no impact on version labels Jul 15, 2022
@codecov
Copy link

codecov bot commented Jul 16, 2022

Codecov Report

Merging #6850 (c4a7121) into maint (8c65776) will increase coverage by 0.98%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##            maint    #6850      +/-   ##
==========================================
+ Coverage   90.25%   91.23%   +0.98%     
==========================================
  Files         354      354              
  Lines       46065    46110      +45     
==========================================
+ Hits        41577    42070     +493     
+ Misses       4488     4040     -448     
Impacted Files Coverage Δ
datalad/core/local/tests/test_status.py 97.79% <100.00%> (ø)
datalad/customremotes/tests/test_datalad.py 95.34% <0.00%> (-2.28%) ⬇️
datalad/distribution/create_sibling.py 69.80% <0.00%> (-0.20%) ⬇️
datalad/cli/common_args.py 100.00% <0.00%> (ø)
datalad/tests/test_dochelpers.py 100.00% <0.00%> (ø)
datalad/support/tests/test_network.py 100.00% <0.00%> (ø)
datalad/tests/utils_pytest.py 89.73% <0.00%> (+0.01%) ⬆️
datalad/utils.py 88.17% <0.00%> (+0.01%) ⬆️
datalad/__init__.py 98.00% <0.00%> (+0.04%) ⬆️
datalad/support/tests/test_locking.py 95.87% <0.00%> (+0.04%) ⬆️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c65776...c4a7121. Read the comment docs.

@yarikoptic
Copy link
Member Author

Ok, it is green and there were requests on matrix to release, so it's do so with this PR.

@yarikoptic yarikoptic added the release Create a release when this pr is merged label Jul 16, 2022
@yarikoptic yarikoptic merged commit e377e54 into datalad:maint Jul 16, 2022
@github-actions
Copy link

🚀 PR was released in 0.17.2 🚀

@yarikoptic yarikoptic deleted the bf-win-symlink branch October 14, 2022 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform-windows Issue concerned with Windows release Create a release when this pr is merged released semver-tests Changes only affect tests, no impact on version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant