Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RF,ENH(TST): future proof testing of git annex version upgrade + test annex init on all supported versions #6880

Merged
merged 1 commit into from
Jul 26, 2022

Conversation

yarikoptic
Copy link
Member

Originally this test was crafted when 6 was still among supported versions.
We have gone past that point now, minimal supported version of git-annex
(from 202003) supports only 8, and current ones default to 8 but support also
9 and 10. I have RF and extended test to to remain valid "forever" and test
that we can init git-annex of any supported version

… annex init on all supported versions

Originally this test was crafted when 6 was still among supported versions.
We have gone past that point now, minimal supported version of git-annex
(from 202003) supports only 8, and current ones default to 8 but support also
9 and 10.  I have RF and extended test to to remain valid "forever" and test
that we can init git-annex of any supported version
@yarikoptic yarikoptic added the semver-tests Changes only affect tests, no impact on version label Jul 24, 2022
@codecov
Copy link

codecov bot commented Jul 24, 2022

Codecov Report

Merging #6880 (ca7460f) into maint (cefecae) will increase coverage by 0.95%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##            maint    #6880      +/-   ##
==========================================
+ Coverage   90.25%   91.21%   +0.95%     
==========================================
  Files         354      354              
  Lines       46113    46123      +10     
==========================================
+ Hits        41621    42070     +449     
+ Misses       4492     4053     -439     
Impacted Files Coverage Δ
datalad/support/tests/test_annexrepo.py 97.82% <100.00%> (+0.07%) ⬆️
datalad/api.py 86.66% <0.00%> (-8.08%) ⬇️
datalad/tests/utils.py 66.76% <0.00%> (+9.73%) ⬆️
datalad/tests/test_tests_utils.py 92.34% <0.00%> (+92.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cefecae...ca7460f. Read the comment docs.

@yarikoptic
Copy link
Member Author

docs known, so likely unrelated. travis - one known and one annoying recent filed #6887 . These two tests passed just fine everywhere

$> git grep test_repo_version | nl | tail -n 2
    43	ca7460f/travis-14312-success/8.txt:../datalad/support/tests/test_annexrepo.py::test_repo_version_upgrade PASSED [ 59%]
    44	ca7460f/travis-14312-success/8.txt:../datalad/support/tests/test_annexrepo.py::test_repo_version_supported[8] PASSED [ 59%]

$> git grep test_repo_version | grep -v PASSED

@yarikoptic yarikoptic merged commit 7d42d20 into datalad:maint Jul 26, 2022
@yarikoptic yarikoptic deleted the enh-annex-supported-versions branch October 14, 2022 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-tests Changes only affect tests, no impact on version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant