Skip to content

ENH(TST): test against supported git annex repo version 10 + make it a full sweep over tests#6881

Merged
yarikoptic merged 1 commit intodatalad:maintfrom
yarikoptic:enh-annex-supported-versions2
Jul 26, 2022
Merged

ENH(TST): test against supported git annex repo version 10 + make it a full sweep over tests#6881
yarikoptic merged 1 commit intodatalad:maintfrom
yarikoptic:enh-annex-supported-versions2

Conversation

@yarikoptic
Copy link
Member

10 is the most recent supported git annex repo version. It should bring improvement
in some operation performance (see e.g.
dandi/dandisets#229 (comment) ). But it is not the
default version git annex would use (it uses 8), so AFAIK there is no "real life" testing
for operation of v10 annex repos. Also we did not do full sweep of testing against python
3.10, so I made second matrix run for it, to which I also added testing against v10. This
way we do not do full combinatorics of python version/git-annex/git-annex repo version but
at least gain 1 environment with 2 matrix runs for full tests sweep in a "most modern
environment" setting

…a full sweep over tests

10 is the most recent supported git annex repo version.  It should bring improvement
in some operation performance (see e.g.
dandi/dandisets#229 (comment) ). But it is not the
default version git annex would use (it uses 8), so AFAIK there is no "real life" testing
for operation of v10 annex repos.  Also we did not do full sweep of testing against python
3.10, so I made second matrix run for it, to which I also added testing against v10.  This
way we do not do full combinatorics of python version/git-annex/git-annex repo version but
at least gain 1 environment with 2 matrix runs for full tests sweep in a "most modern
environment" setting
@codecov
Copy link

codecov bot commented Jul 24, 2022

Codecov Report

Merging #6881 (5ae1b46) into maint (cefecae) will increase coverage by 0.96%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            maint    #6881      +/-   ##
==========================================
+ Coverage   90.25%   91.22%   +0.96%     
==========================================
  Files         354      354              
  Lines       46113    46134      +21     
==========================================
+ Hits        41621    42086     +465     
+ Misses       4492     4048     -444     
Impacted Files Coverage Δ
datalad/api.py 86.66% <0.00%> (-8.08%) ⬇️
datalad/customremotes/tests/test_datalad.py 95.34% <0.00%> (-2.28%) ⬇️
datalad/distribution/create_sibling.py 69.80% <0.00%> (-0.20%) ⬇️
datalad/cli/common_args.py 100.00% <0.00%> (ø)
datalad/tests/test_dochelpers.py 100.00% <0.00%> (ø)
datalad/support/tests/test_network.py 100.00% <0.00%> (ø)
datalad/tests/utils_pytest.py 89.73% <0.00%> (+0.01%) ⬆️
datalad/utils.py 88.17% <0.00%> (+0.01%) ⬆️
datalad/__init__.py 98.00% <0.00%> (+0.04%) ⬆️
datalad/support/tests/test_locking.py 95.87% <0.00%> (+0.04%) ⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cefecae...5ae1b46. Read the comment docs.

@yarikoptic yarikoptic added the semver-internal Changes only affect the internal API label Jul 24, 2022
@yarikoptic
Copy link
Member Author

docs is independent issue, the only travis failing run due to #6887 , restarted to see if goes away

@yarikoptic yarikoptic merged commit 4cca50c into datalad:maint Jul 26, 2022
@yarikoptic yarikoptic deleted the enh-annex-supported-versions2 branch October 14, 2022 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver-internal Changes only affect the internal API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant