Skip to content

RF: just rename internal variable from unclear "op" to "io" #6907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 3, 2022

Conversation

yarikoptic
Copy link
Member

came up while chatting with @Aksoo about #4598 .
That use of "op" (what does it stand for) was a "false positive" in trying to find
all uses of os.path

came up while chatting with @Aksoo about #4598 .
That use of "op" (what does it stand for) was a "false positive" in trying to find
all uses of os.path
@yarikoptic yarikoptic marked this pull request as ready for review August 2, 2022 13:31
Copy link
Member

@adswa adswa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me

@yarikoptic yarikoptic added the semver-internal Changes only affect the internal API label Aug 3, 2022
@yarikoptic
Copy link
Member Author

CI - unrelated... damn them. merging

@yarikoptic yarikoptic merged commit 91e1558 into maint Aug 3, 2022
@yarikoptic yarikoptic deleted the rf-minor branch August 3, 2022 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-internal Changes only affect the internal API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants