BF(TST,workaround): just xfail failing archives test on NFS #6912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A workaround for datalad#4101 with troubleshooting and trying various approaches done within datalad#6751 An ideal approach would be to check if create_tree does create a tree (and archives with files it expect) matching the specification of the tree. Somehow on NFS it seems to need some times a few seconds (sleep 3 before creating archive helped according to testing in datalad#6751) before filesystem actually reflect creation of all files desired. I found no robust solution which would not require "too much work" so decided to just announce this an xfail. For better or for worse, the loop of 100 invocations had them all PASS and none XFAIL in https://app.travis-ci.com/github/datalad/datalad/builds/253793240 so the effectiveness of this is not exactly confirmed yet ;)
yarikoptic
added
tests
|
travis - 3.10 , another PR to fix it... all good for this xfail AFAIK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A workaround for #4101
with troubleshooting and trying various approaches done within
#6751
An ideal approach would be to check if create_tree does create a tree (and
archives with files it expect) matching the specification of the tree. Somehow
on NFS it seems to need some times a few seconds (sleep 3 before creating
archive helped according to testing in #6751) before filesystem actually reflect
creation of all files desired.
I found no robust solution which would not require "too much work" so decided
to just announce this an xfail.
For better or for worse, the loop of 100 invocations had them all PASS and none
XFAIL in https://app.travis-ci.com/github/datalad/datalad/builds/253793240 so
the effectiveness of this is not exactly confirmed yet ;)