Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: travis - mark our directory as safe to interact with as root #6919

Merged
merged 1 commit into from
Aug 5, 2022

Conversation

yarikoptic
Copy link
Member

The last commit from #6913

We are doing sudo pip install but that then causes versioneer to run
git, and a recent git would fail with the message like

$ sudo git "rev-parse" "--git-dir"
fatal: unsafe repository ('/home/travis/build/datalad/datalad' is owned by someone else)
To add an exception for this directory, call:
	git config --global --add safe.directory /home/travis/build/datalad/datalad
The command "sudo git "rev-parse" "--git-dir"" exited with 128.

so here we do what it asks us.

Fixes #6887
Closes #6913

We are doing   sudo pip install   but that then causes versioneer to run
git, and a recent git would fail with the message like

	$ sudo git "rev-parse" "--git-dir"
	fatal: unsafe repository ('/home/travis/build/datalad/datalad' is owned by someone else)
	To add an exception for this directory, call:
		git config --global --add safe.directory /home/travis/build/datalad/datalad
	The command "sudo git "rev-parse" "--git-dir"" exited with 128.

so here we do what it asks us.

Fixes datalad#6887
@yarikoptic yarikoptic added the semver-internal Changes only affect the internal API label Aug 4, 2022
@yarikoptic
Copy link
Member Author

Since I do not think we could do anything differently to just resolve this issue, I will just wait for CI to turn green and merge.

@yarikoptic yarikoptic marked this pull request as ready for review August 4, 2022 22:37
@codecov
Copy link

codecov bot commented Aug 4, 2022

Codecov Report

Merging #6919 (f8dcbf9) into maint (f4726d8) will increase coverage by 0.79%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            maint    #6919      +/-   ##
==========================================
+ Coverage   90.15%   90.94%   +0.79%     
==========================================
  Files         354      354              
  Lines       46221    46246      +25     
==========================================
+ Hits        41670    42058     +388     
+ Misses       4551     4188     -363     
Impacted Files Coverage Δ
datalad/version.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/support/nda_.py 0.00% <0.00%> (-54.55%) ⬇️
datalad/support/network.py 87.30% <0.00%> (-3.94%) ⬇️
datalad/support/s3.py 40.00% <0.00%> (-3.40%) ⬇️
datalad/tests/test_archives.py 91.91% <0.00%> (-2.75%) ⬇️
datalad/customremotes/tests/test_datalad.py 95.34% <0.00%> (-2.28%) ⬇️
datalad/downloaders/http.py 77.43% <0.00%> (-1.74%) ⬇️
datalad/utils.py 86.49% <0.00%> (-1.67%) ⬇️
datalad/support/exceptions.py 83.79% <0.00%> (-0.93%) ⬇️
datalad/downloaders/providers.py 95.33% <0.00%> (-0.85%) ⬇️
... and 32 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@yarikoptic
Copy link
Member Author

Wow, datalad crawler managed to stall a new way

Screenshot_20220805-002841

I cancelled it. Travis is happy and that is what matters here

@yarikoptic yarikoptic merged commit 8119456 into datalad:maint Aug 5, 2022
@yarikoptic yarikoptic deleted the bf-3.10-versioneer-actually branch October 14, 2022 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-internal Changes only affect the internal API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant