BF+ENH(TST): fix typo in code of wtf filesystems reports#6920
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## maint #6920 +/- ##
=======================================
Coverage 90.03% 90.03%
=======================================
Files 354 354
Lines 46246 46246
Branches 6595 6595
=======================================
Hits 41637 41637
Misses 4593 4593
Partials 16 16 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Detected while looking at datalad#6917 (comment)
Even if it would be too noisy on windows -- would still be better than just silently not working correctly (as it was due to a typo). And if psutil is not installed, we would get it logged only at debug level. But otherwise, if something abnormal -- at warning level and reported once (although could be different for different filesystems, but at least would alert to a possible next typo)
yarikoptic
force-pushed
the
bf-wtf-filesystem
branch
from
74f1288 to
9c9c34c
Compare
Member
Author
|
FWIW I have CPed the actual fix (b5fd8cd) into |
adswa
approved these changes
Aug 15, 2022
adswa
left a comment
adswa
left a comment
Member
There was a problem hiding this comment.
Thanks for catching this, and adding a test. And sorry for the vacation-related delay
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detected while looking at #6917 (comment) and it was impossible to detect that there is an underlying issue in the code since no logging and swallowing of all exceptions silently. Added logging, and some rudimentary testing (let's see if works on windows. edit: appveyor was green, so I guess it did!).