Skip to content

DOC: fix capitalization of some service names #6936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 12, 2022

Conversation

aqw
Copy link
Contributor

@aqw aqw commented Aug 12, 2022

I noticed a "Github" in a config file while helping someone with DataLad, and it caused me to twitch enough to fix it and a few other strings I found. ;-)

This is by no means comprehensive, but I did some greping around and tried to catch all I could find.

I intentionally chose to not fix occurrences in code comments and tests.

  • Github -> GitHub
  • openfmri -> OpenfMRI
  • s3 -> S3
  • travis -> Travis CI

This also fixes "Datalad" mis-capitalizations. For this, I did fix all occurrences, to make future greping easier.

  • Datalad -> DataLad

Changelog

📝 Documentation

  • fix capitalization of some service and software names

@aqw
Copy link
Contributor Author

aqw commented Aug 12, 2022

Well, it seems like most tests fail. But I don't know if that's significant or normal.

If it's atypical, let me know and I'll take a look. But these changes aren't all that important, so it's not worth a tooling struggle to get them in.

@aqw aqw changed the title fix capitalization of some service names DOCFIX: fix capitalization of some service names Aug 12, 2022
aqw added 2 commits August 12, 2022 11:05
Github -> GitHub
openfmri -> OpenfMRI
s3 -> S3
travis -> Travis CI

I chose to not fix code comments nor tests.
@aqw aqw changed the title DOCFIX: fix capitalization of some service names DOC: fix capitalization of some service names Aug 12, 2022
@codeclimate
Copy link

codeclimate bot commented Aug 12, 2022

Code Climate has analyzed commit 6b7a2f7 and detected 0 issues on this pull request.

View more on Code Climate.

@yarikoptic
Copy link
Member

Looks good to me. I will need to cherrypick it into maint.. CI - hopefully we would fix it soon (not our fault)

@yarikoptic yarikoptic merged commit bacdc8e into datalad:master Aug 12, 2022
@yarikoptic-gitmate
Copy link
Collaborator

PR released in 0.18.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants