BF: git_ignore_check do not overload possible value of stdout/err if present#6937
Merged
Merged
Conversation
…present A little more discussion at datalad#6930 and initially identified while working on datalad#6932 and being unable to get CommandError.stdout for matching while using call_git (but works with _call_git using different code path, which does not have this git_ignore_check). One of the two locations where this function is used has stdout=None, so this lead to wiping out of e.stdout even if it was present. I think it was not intentional but @christian-monch would know better
Codecov Report
@@ Coverage Diff @@
## maint #6937 +/- ##
==========================================
+ Coverage 89.96% 90.94% +0.98%
==========================================
Files 354 354
Lines 46250 46250
==========================================
+ Hits 41609 42064 +455
+ Misses 4641 4186 -455
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Member
Author
|
woohoo -- it is green! only crawler wants something but I do not think it is related -- I saw it failing in other PRs. |
christian-monch
approved these changes
Aug 23, 2022
christian-monch
approved these changes
Aug 23, 2022
Contributor
christian-monch
left a comment
christian-monch
left a comment
There was a problem hiding this comment.
Good extension to other use cases, thx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A little more discussion at #6930 and initially
identified while working on #6932 and being
unable to get CommandError.stdout for matching while using call_git (but works
with _call_git using different code path, which does not have this git_ignore_check).
One of the two locations where this function is used has stdout=None, so this
lead to wiping out of e.stdout even if it was present. I think it was not intentional
but @christian-monch would know better