Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Acknowledge git-config comment chars #6944

Merged
merged 3 commits into from
Aug 18, 2022
Merged

Acknowledge git-config comment chars #6944

merged 3 commits into from
Aug 18, 2022

Conversation

mih
Copy link
Member

@mih mih commented Aug 15, 2022

Previously we ignored them in values as mandatory reasons for quoting.
This change expands the quote_config() helper to perform this
additional test.

Fixes #6943

@mih mih added the semver-patch Increment the patch version when merged label Aug 15, 2022
@mih mih mentioned this pull request Aug 15, 2022
Closed
@mih
Acknowledge git-config comment chars
3f5fa2b 
Previously we ignored them in values as mandatory reasons for quoting.
This change expands the `quote_config()` helper to perform this
additional test.

Fixes datalad#6943
@mih
Copy link
Member Author

mih commented Aug 15, 2022

Crawler test failure is unrelated and occurs elsewhere too.

@codecov
Copy link

codecov bot commented Aug 15, 2022 •
edited
Loading

Codecov Report

Merging #6944 (15b2794) into maint (8fec36a) will increase coverage by 0.99%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##            maint    #6944      +/-   ##
==========================================
+ Coverage   89.96%   90.95%   +0.99%     
==========================================
  Files         354      354              
  Lines       46257    46261       +4     
==========================================
+ Hits        41615    42079     +464     
+ Misses       4642     4182     -460
Impacted Files Coverage Δ
datalad/config.py 97.26% <100.00%> (+<0.01%) ⬆️
datalad/tests/test_config.py 99.73% <100.00%> (+<0.01%) ⬆️
datalad/_version.py 45.68% <0.00%> (-0.28%) ⬇️
...talad/distributed/tests/test_create_sibling_ria.py 100.00% <0.00%> (ø)
datalad/distribution/utils.py 94.00% <0.00%> (+2.00%) ⬆️
datalad/distributed/create_sibling_ria.py 84.11% <0.00%> (+2.35%) ⬆️
datalad/tests/utils.py 65.10% <0.00%> (+11.03%) ⬆️
datalad/tests/test_tests_utils.py 92.34% <0.00%> (+92.34%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

yarikoptic
yarikoptic requested changes Aug 17, 2022
View reviewed changes
Copy link
Member

@yarikoptic yarikoptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not hardcode unicode in the test. IMHO no need for windows conditioning right there.

datalad/tests/test_config.py Outdated Show resolved Hide resolved
@mih mih requested a review from yarikoptic August 17, 2022 14:49
@adswa adswa merged commit 4ecffe8 into datalad:maint Aug 18, 2022
@adswa adswa deleted the bf-6943 branch August 18, 2022 11:35
@yarikoptic yarikoptic mentioned this pull request Aug 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yarikoptic yarikoptic yarikoptic approved these changes

Assignees
No one assigned
Labels
semver-patch Increment the patch version when merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mih @yarikoptic @adswa