Acknowledge git-config comment chars#6944
Merged
Merged
Conversation
Previously we ignored them in values as mandatory reasons for quoting. This change expands the `quote_config()` helper to perform this additional test. Fixes datalad#6943
Member
Author
|
Crawler test failure is unrelated and occurs elsewhere too. |
Codecov Report
@@ Coverage Diff @@
## maint #6944 +/- ##
==========================================
+ Coverage 89.96% 90.95% +0.99%
==========================================
Files 354 354
Lines 46257 46261 +4
==========================================
+ Hits 41615 42079 +464
+ Misses 4642 4182 -460
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
yarikoptic
requested changes
Aug 17, 2022
Member
yarikoptic
left a comment
yarikoptic
left a comment
There was a problem hiding this comment.
Please do not hardcode unicode in the test. IMHO no need for windows conditioning right there.
Thanks to @yarikoptic for pointing this out.
yarikoptic
reviewed
Aug 17, 2022
yarikoptic
approved these changes
Aug 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we ignored them in values as mandatory reasons for quoting.
This change expands the
quote_config()helper to perform thisadditional test.
Fixes #6943