Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: Remove duplicate key in result record #6952

Merged
merged 2 commits into from
Aug 17, 2022
Merged

Conversation

adswa
Copy link
Member

@adswa adswa commented Aug 17, 2022

Should be a fix and testcase for #6950.

Changelog

🐛 Bug Fixes

  • When create-sibling-ria was invoked with a sibling name of a pre-existing sibling, a duplicate key in the result record caused a crashed. This was fixed.

@adswa adswa added the semver-patch Increment the patch version when merged label Aug 17, 2022
@codeclimate
Copy link

codeclimate bot commented Aug 17, 2022

Code Climate has analyzed commit 07c596f and detected 0 issues on this pull request.

View more on Code Climate.

@adswa adswa linked an issue Aug 17, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Aug 17, 2022

Codecov Report

Merging #6952 (07c596f) into master (bacdc8e) will increase coverage by 12.66%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master    #6952       +/-   ##
===========================================
+ Coverage   78.29%   90.96%   +12.66%     
===========================================
  Files         354      354               
  Lines       46259    46275       +16     
===========================================
+ Hits        36219    42094     +5875     
+ Misses      10040     4181     -5859     
Impacted Files Coverage Δ
datalad/distributed/create_sibling_ria.py 84.11% <ø> (+21.76%) ⬆️
...talad/distributed/tests/test_create_sibling_ria.py 100.00% <100.00%> (+60.98%) ⬆️
datalad/customremotes/tests/test_datalad.py 95.34% <0.00%> (-2.28%) ⬇️
datalad/cli/common_args.py 100.00% <0.00%> (ø)
datalad/tests/test_dochelpers.py 100.00% <0.00%> (ø)
datalad/support/tests/test_network.py 100.00% <0.00%> (ø)
datalad/support/tests/test_locking.py 95.87% <0.00%> (+0.04%) ⬆️
datalad/customremotes/tests/test_archives.py 89.36% <0.00%> (+0.07%) ⬆️
datalad/local/tests/test_addurls.py 99.57% <0.00%> (+0.21%) ⬆️
datalad/config.py 97.26% <0.00%> (+0.22%) ⬆️
... and 138 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@yarikoptic
Copy link
Member

Looks great to me @adswa , I will need to manually CP it to maint though

@yarikoptic yarikoptic merged commit 2c00733 into datalad:master Aug 17, 2022
@adswa adswa deleted the bf-6950 branch August 17, 2022 12:47
@adswa
Copy link
Member Author

adswa commented Aug 17, 2022

argh I can never remember to pick the right base...

@yarikoptic-gitmate
Copy link
Collaborator

PR released in 0.18.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error result generation crashes with --existing=error (default)
3 participants