BF: Remove duplicate key in result record#6952
Merged
yarikoptic merged 2 commits intodatalad:masterfrom Aug 17, 2022
Merged
Conversation
|
Code Climate has analyzed commit 07c596f and detected 0 issues on this pull request. View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## master #6952 +/- ##
===========================================
+ Coverage 78.29% 90.96% +12.66%
===========================================
Files 354 354
Lines 46259 46275 +16
===========================================
+ Hits 36219 42094 +5875
+ Misses 10040 4181 -5859
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Member
|
Looks great to me @adswa , I will need to manually CP it to maint though |
Member
Author
|
argh I can never remember to pick the right base... |
Collaborator
|
PR released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should be a fix and testcase for #6950.
Changelog
🐛 Bug Fixes
create-sibling-riawas invoked with a sibling name of a pre-existing sibling, a duplicate key in the result record caused a crashed. This was fixed.