Provide "/dev/null" (b:\nul on 💾 Windows) instead of empty string as a git-repo to avoid reading local repo configuration #6986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As it was reported in datalad#6815 and inquired from git folks for a better solution (no reply yet) at https://lore.kernel.org/git/YscCKuoDPBbs4iPX@lena.dartmouth.edu/T/#u whenever we provide an empty value for --git-dir, iff there is includeIf statement in config, then git starts to demand a non-empty value for that setting. Unfortunately RTFM does not give any clear answer either that is a legit or not. So I have decided to replace one questionable use with another which does not cause an error. Anther alternative I found we could have used two separate invocations of --system and --global, but we cannot use them at the same time.
More information in the diff in comments. b - used to be used for "second floppy drive", less likely to be used these days nul - corresponds to something like /dev/null on any drive. Although could be created (via some other syscalls, like FAR manager does) a very unlikely to be present.
Codecov Report
@@ Coverage Diff @@
## maint #6986 +/- ##
==========================================
+ Coverage 90.25% 91.12% +0.87%
==========================================
Files 354 354
Lines 46057 46354 +297
Branches 0 6612 +6612
==========================================
+ Hits 41567 42241 +674
+ Misses 4490 4097 -393
- Partials 0 16 +16
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
yarikoptic
changed the title
yarikoptic
changed the title
yarikoptic
changed the title
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is the resurrected #6820 but now with "Windows support". More information/references in the diff itself and individual commits.
Closes #6815