Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use scriv for CHANGELOG generation in release workflow #7009

Merged
merged 3 commits into from
Sep 7, 2022

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Sep 2, 2022

Part of #6918.

@jwodder jwodder added semver-internal Changes only affect the internal API CHANGELOG-missing When a PR's description does not contain a changelog item, yet. labels Sep 2, 2022
@github-actions github-actions bot removed the CHANGELOG-missing When a PR's description does not contain a changelog item, yet. label Sep 2, 2022
Copy link
Member

@yarikoptic yarikoptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor questions/comments. Otherwise -- looks worth trying! Thank you!

.github/workflows/release.yml Show resolved Hide resolved
changelog.d/templates/entry_title.md.j2 Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 6, 2022

Codecov Report

Merging #7009 (22beee9) into maint (5767ee4) will increase coverage by 4.36%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            maint    #7009      +/-   ##
==========================================
+ Coverage   71.83%   76.19%   +4.36%     
==========================================
  Files         354      354              
  Lines       58618    58751     +133     
  Branches     6613     6613              
==========================================
+ Hits        42108    44766    +2658     
+ Misses      16495    13970    -2525     
  Partials       15       15              
Impacted Files Coverage Δ
datalad/cmd.py 75.33% <0.00%> (-4.44%) ⬇️
datalad/customremotes/tests/test_datalad.py 87.23% <0.00%> (-1.90%) ⬇️
datalad/_version.py 45.68% <0.00%> (-0.28%) ⬇️
datalad/distribution/create_sibling.py 60.48% <0.00%> (-0.15%) ⬇️
datalad/runner/runner.py 100.00% <0.00%> (ø)
datalad/cli/common_args.py 100.00% <0.00%> (ø)
datalad/support/tests/test_network.py 69.09% <0.00%> (+0.07%) ⬆️
datalad/customremotes/tests/test_archives.py 89.36% <0.00%> (+0.07%) ⬆️
datalad/support/gitrepo.py 84.25% <0.00%> (+0.11%) ⬆️
datalad/dochelpers.py 85.71% <0.00%> (+0.12%) ⬆️
... and 100 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@yarikoptic yarikoptic added the release Create a release when this pr is merged label Sep 7, 2022
@yarikoptic
Copy link
Member

ok, and with this we will test if it all works -- added a release label. Thank you @jwodder

@yarikoptic-gitmate
Copy link
Collaborator

PR released in 0.17.6

@jwodder jwodder deleted the gh-6918b branch May 12, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Create a release when this pr is merged semver-internal Changes only affect the internal API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants