Skip to content

Allow for any 2 from first 3 to be consumed in test_gracefull_death#7041

Merged
mih merged 2 commits into
datalad:maintfrom
yarikoptic:bf-5309
Sep 16, 2022
Merged

Allow for any 2 from first 3 to be consumed in test_gracefull_death#7041
mih merged 2 commits into
datalad:maintfrom
yarikoptic:bf-5309

Conversation

@yarikoptic
Copy link
Copy Markdown
Member

@yarikoptic yarikoptic commented Sep 15, 2022

Resolves flaky test on CIs which kept hunting us for awhile and has nothing to do with OSX specifically. Closes #5309

Kept annoying us for awhile!

Closes #5309

…full_death

Resolves flaky test on CIs which kept hunting us for awhile and has
nothing to do with OSX specifically.  Closes datalad#5309
@yarikoptic yarikoptic added semver-tests Changes only affect tests, no impact on version CHANGELOG-missing When a PR's description does not contain a changelog item, yet. labels Sep 15, 2022
@github-actions github-actions Bot removed the CHANGELOG-missing When a PR's description does not contain a changelog item, yet. label Sep 15, 2022
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 16, 2022

Codecov Report

Base: 75.43% // Head: 88.85% // Increases project coverage by +13.41% 🎉

Coverage data is based on head (6de3d57) compared to base (91f6949).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##            maint    #7041       +/-   ##
===========================================
+ Coverage   75.43%   88.85%   +13.41%     
===========================================
  Files         354      354               
  Lines       58750    46444    -12306     
  Branches     6613        0     -6613     
===========================================
- Hits        44319    41268     -3051     
+ Misses      14417     5176     -9241     
+ Partials       14        0       -14     
Impacted Files Coverage Δ
datalad/support/tests/test_parallel.py 94.81% <100.00%> (+9.38%) ⬆️
datalad/cmdline/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/interface/run_procedure.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/cmdline/helpers.py 0.00% <0.00%> (-78.27%) ⬇️
datalad/support/nda_.py 0.00% <0.00%> (-54.55%) ⬇️
datalad/__main__.py 39.65% <0.00%> (-29.32%) ⬇️
datalad/distribution/uninstall.py 63.26% <0.00%> (-28.58%) ⬇️
datalad/tests/utils.py 21.60% <0.00%> (-27.05%) ⬇️
datalad/api.py 75.60% <0.00%> (-15.51%) ⬇️
datalad/support/entrypoints.py 50.00% <0.00%> (-10.53%) ⬇️
... and 187 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Copy Markdown
Member

@mih mih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@yarikoptic-gitmate
Copy link
Copy Markdown
Collaborator

PR released in 0.17.6

@yarikoptic yarikoptic deleted the bf-5309 branch October 14, 2022 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver-tests Changes only affect tests, no impact on version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants