Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt tests to modified command group names #7044

Merged

Conversation

christian-monch
Copy link
Contributor

@christian-monch christian-monch commented Sep 16, 2022

This PR fixes the test that verifies the command group names. It basically adapts the verified command group names to the changes from 8decbdc. This should fix a bunch of failing tests on master that are run on Travis and Appveyor

Changelog

🏠 Internal

  • Fix an error in the command group names-test

This commit fixes the test that verifies the
command group names. It basically adapts the
verified command group names to the changes
from 8decbdc
@christian-monch christian-monch added the semver-tests Changes only affect tests, no impact on version label Sep 16, 2022
@christian-monch christian-monch requested a review from mih September 16, 2022 06:48
@codeclimate
Copy link

codeclimate bot commented Sep 16, 2022

Code Climate has analyzed commit 514b609 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Sep 16, 2022

Codecov Report

Base: 75.07% // Head: 76.01% // Increases project coverage by +0.94% 🎉

Coverage data is based on head (514b609) compared to base (afab8db).
Patch coverage: 87.54% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7044      +/-   ##
==========================================
+ Coverage   75.07%   76.01%   +0.94%     
==========================================
  Files         354      357       +3     
  Lines       58609    59213     +604     
  Branches     6610     6615       +5     
==========================================
+ Hits        43998    45010    +1012     
+ Misses      14595    14187     -408     
  Partials       16       16              
Impacted Files Coverage Δ
datalad/cli/parser.py 60.99% <ø> (-23.25%) ⬇️
datalad/interface/__init__.py 100.00% <ø> (ø)
datalad/core/distributed/clone.py 65.39% <82.51%> (-23.89%) ⬇️
datalad/core/distributed/clone_ria.py 88.23% <88.23%> (ø)
datalad/core/distributed/clone_utils.py 89.57% <89.57%> (ø)
datalad/core/distributed/clone_ephemeral.py 91.30% <91.30%> (ø)
datalad/cli/tests/test_main.py 62.99% <100.00%> (ø)
datalad/core/distributed/tests/test_clone.py 75.48% <100.00%> (+0.27%) ⬆️
... and 47 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@christian-monch
Copy link
Contributor Author

This fixes a superset of the errors that are addressed in PR #7042. Merging this PR would therefore obsolete PR #7042

Copy link
Member

@mih mih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx! LGTM!

@christian-monch christian-monch merged commit 5fa362e into datalad:master Sep 16, 2022
@christian-monch christian-monch deleted the fix-command-group-test branch September 16, 2022 08:15
@yarikoptic-gitmate
Copy link
Collaborator

PR released in 0.18.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-tests Changes only affect tests, no impact on version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants