Let EnsureChoice report the value is failed validating#7067
Merged
Conversation
yarikoptic
approved these changes
Oct 7, 2022
yarikoptic
left a comment
yarikoptic
left a comment
Member
There was a problem hiding this comment.
I am always for more informative error messages. Failing CI should be checked to not be related (if eg we rely somewhere in matching that message)
yarikoptic
added
the
CHANGELOG-missing
github-actions
Bot
removed
the
CHANGELOG-missing
bpoldrack
approved these changes
Oct 7, 2022
bpoldrack
left a comment
bpoldrack
left a comment
Member
There was a problem hiding this comment.
Approving but not yet merging, since tests aren't finished and I want to see them (for entirely unrelated to this PR reasons, though). Confident, that failures are unrelated (already saw one, that is highly likely to be same as #6599).
Member
|
Ok, still sure the CI failures need addressing elsewhere. Merging. Thx, @mih. |
Collaborator
|
PR released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just that. Feel free to reject. It was just bothering me enough that I had this change in my local deployment to help me figure what is actually happening.