Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let EnsureChoice report the value is failed validating #7067

Merged
merged 2 commits into from
Oct 8, 2022

Conversation

mih
Copy link
Member

@mih mih commented Oct 6, 2022

Just that. Feel free to reject. It was just bothering me enough that I had this change in my local deployment to help me figure what is actually happening.

@mih mih added the semver-patch Increment the patch version when merged label Oct 6, 2022
Copy link
Member

@yarikoptic yarikoptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am always for more informative error messages. Failing CI should be checked to not be related (if eg we rely somewhere in matching that message)

@yarikoptic yarikoptic added the CHANGELOG-missing When a PR's description does not contain a changelog item, yet. label Oct 7, 2022
@github-actions github-actions bot removed the CHANGELOG-missing When a PR's description does not contain a changelog item, yet. label Oct 7, 2022
Copy link
Member

@bpoldrack bpoldrack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving but not yet merging, since tests aren't finished and I want to see them (for entirely unrelated to this PR reasons, though). Confident, that failures are unrelated (already saw one, that is highly likely to be same as #6599).

@bpoldrack
Copy link
Member

Ok, still sure the CI failures need addressing elsewhere. Merging.

Thx, @mih.

@bpoldrack bpoldrack merged commit dc5b4c7 into datalad:maint Oct 8, 2022
@mih mih deleted the bf-constraint branch October 14, 2022 15:46
@yarikoptic-gitmate
Copy link
Collaborator

PR released in 0.17.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants