RF: remove unused code str-ing PurePath#7073
Merged
Merged
Conversation
Is of no use since we operate on path_ not path down below that block. Originally introduced in b0258db (datalad#3191). Should be safe since RI which is coming next can take Path just fine: ❯ python -c 'from pathlib import Path; from datalad.support.network import RI; print(repr(RI(Path("/home"))))' PathRI(path='/home') ❯ python -c 'from pathlib import Path; from datalad.support.network import RI; print(repr(RI("/home")))' PathRI(path='/home')
Codecov ReportBase: 74.76% // Head: 75.46% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## maint #7073 +/- ##
==========================================
+ Coverage 74.76% 75.46% +0.69%
==========================================
Files 354 354
Lines 58945 58946 +1
Branches 6310 6309 -1
==========================================
+ Hits 44072 44482 +410
+ Misses 14858 14449 -409
Partials 15 15
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
yarikoptic
added
CHANGELOG-missing
github-actions
Bot
removed
the
CHANGELOG-missing
yarikoptic
added
CHANGELOG-missing
github-actions
Bot
removed
the
CHANGELOG-missing
bpoldrack
approved these changes
Oct 8, 2022
Collaborator
|
PR released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Is of no use since we operate on path_ not path down below that block. Originally introduced in b0258db (#3191).
Should be safe since RI which is coming next can take Path just fine: