Skip to content

Add a way to specify description when creating github-like siblings#7109

Merged
bpoldrack merged 5 commits intodatalad:masterfrom
mslw:nf-ghlike-description
Nov 1, 2022
Merged

Add a way to specify description when creating github-like siblings#7109
bpoldrack merged 5 commits intodatalad:masterfrom
mslw:nf-ghlike-description

Conversation

@mslw
Copy link
Copy Markdown
Contributor

@mslw mslw commented Oct 24, 2022

This PR adds an optional description parameter to create_sibling_ghlike, and enables it for related (gin / gitea / github / gogs) create-sibling commands. This optional parameter allows specification of repository description (displayed on the project's page), replacing the hardcoded 'some default' (which would still be used the default).

Manually tested for Gin and GitHub.

Fixes #6816

mslw added 3 commits October 24, 2022 13:25
This optional parameter allows specification of repository
description, instead of hardcoded 'some default' (which remains the
default).
@mslw mslw added the semver-minor Increment the minor version when merged label Oct 24, 2022
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 24, 2022

Codecov Report

Base: 89.42% // Head: 90.96% // Increases project coverage by +1.54% 🎉

Coverage data is based on head (f583c44) compared to base (2346326).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head f583c44 differs from pull request most recent head fd740de. Consider uploading reports for the commit fd740de to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7109      +/-   ##
==========================================
+ Coverage   89.42%   90.96%   +1.54%     
==========================================
  Files         358      358              
  Lines       46553    46554       +1     
  Branches     6322     6322              
==========================================
+ Hits        41628    42348     +720     
+ Misses       4910     4191     -719     
  Partials       15       15              
Impacted Files Coverage Δ
datalad/distributed/create_sibling_gin.py 83.87% <ø> (ø)
datalad/distributed/create_sibling_gitea.py 60.52% <ø> (ø)
datalad/distributed/create_sibling_github.py 52.94% <ø> (ø)
datalad/distributed/create_sibling_gogs.py 100.00% <ø> (ø)
datalad/distributed/create_sibling_ghlike.py 64.83% <100.00%> (+0.19%) ⬆️
datalad/metadata/aggregate.py 75.37% <0.00%> (-0.60%) ⬇️
datalad/metadata/metadata.py 88.88% <0.00%> (-0.53%) ⬇️
datalad/metadata/search.py 89.15% <0.00%> (-0.44%) ⬇️
datalad/_version.py 45.68% <0.00%> (+0.27%) ⬆️
datalad/__init__.py 98.00% <0.00%> (+16.00%) ⬆️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Comment thread changelog.d/20221024_144940_m.szczepanik_nf_ghlike_description.md Outdated
@yarikoptic
Copy link
Copy Markdown
Member

travis errors are due to odd behavior of pip installing older version of datalad-installer

0.81s$ pip install datalad-installer
Collecting datalad-installer
  Downloading datalad_installer-0.5.4-py3-none-any.whl (22 kB)
Installing collected packages: datalad-installer
Successfully installed datalad-installer-0.5.4
0.07s$ eval datalad-installer --sudo ok -E new.env ${_DL_ANNEX_INSTALL_SCENARIO}
Usage: datalad-installer [<options>] miniconda [<options>]
option --python-match not recognized

(current only is v0.9.1-7-ge3aa0ee) for pythons 3.8, 3.9, 3.10

@jwodder -- any idea on why it could have happened all of a sudden?

@jwodder
Copy link
Copy Markdown
Contributor

jwodder commented Oct 24, 2022

@yarikoptic There was an issue in the past hour with PyPI backends being unavailable; see https://status.python.org/#past-incidents. Can you rerun the builds?

@yarikoptic
Copy link
Copy Markdown
Member

Thank you @jwodder ! Finally travis let me to login (can't before earlier today) so I restarted travis build.

Co-authored-by: Yaroslav Halchenko <debian@onerussian.com>
@bpoldrack
Copy link
Copy Markdown
Member

Restarted extension test that should be fixed by now.
Ignore the failure on macOS - this is unrelated. Trial to rectify this is #7126

@qlty-cloud-legacy
Copy link
Copy Markdown

Code Climate has analyzed commit fd740de and detected 0 issues on this pull request.

View more on Code Climate.

@bpoldrack
Copy link
Copy Markdown
Member

Ok, passed.

Thx, @mslw

@bpoldrack bpoldrack merged commit 05597cb into datalad:master Nov 1, 2022
@yarikoptic-gitmate
Copy link
Copy Markdown
Collaborator

PR released in 0.18.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver-minor Increment the minor version when merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Is there a way to manually change the repo description via create-sibling-github?

5 participants