Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various small fixups ran after looking post-release and trying to build Debian package #7112

Merged
merged 4 commits into from
Oct 25, 2022

Conversation

yarikoptic
Copy link
Member

Dear @datalad/developers and @datalad/contributors , please

  • add .md to changelog snippets you might decide to produce/rename manually
  • use tests.utils_pytest not tests.utils (old, nose version, we should look to remove it probably after some minor major release)
  • (reminder to myself as well) - do not forget to r"" raw strings with escapes (e.g. r"\[")

@yarikoptic yarikoptic added semver-patch Increment the patch version when merged CHANGELOG-missing When a PR's description does not contain a changelog item, yet. labels Oct 24, 2022
@yarikoptic yarikoptic marked this pull request as ready for review October 24, 2022 23:53
@github-actions github-actions bot removed the CHANGELOG-missing When a PR's description does not contain a changelog item, yet. label Oct 24, 2022
@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Base: 89.32% // Head: 90.95% // Increases project coverage by +1.63% 🎉

Coverage data is based on head (ca608d8) compared to base (969bb82).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##            maint    #7112      +/-   ##
==========================================
+ Coverage   89.32%   90.95%   +1.63%     
==========================================
  Files         355      355              
  Lines       46497    46497              
  Branches     6327     6327              
==========================================
+ Hits        41535    42293     +758     
+ Misses       4947     4189     -758     
  Partials       15       15              
Impacted Files Coverage Δ
datalad/cli/tests/test_main.py 95.42% <100.00%> (ø)
datalad/metadata/tests/test_metadata.py 100.00% <100.00%> (ø)
datalad/_version.py 45.68% <0.00%> (ø)
datalad/support/annexrepo.py 90.62% <0.00%> (+0.08%) ⬆️
datalad/distribution/tests/test_create_sibling.py 79.83% <0.00%> (+0.21%) ⬆️
datalad/log.py 88.44% <0.00%> (+0.39%) ⬆️
datalad/local/addurls.py 94.95% <0.00%> (+0.45%) ⬆️
datalad/utils.py 88.10% <0.00%> (+0.52%) ⬆️
datalad/core/local/create.py 99.29% <0.00%> (+0.70%) ⬆️
datalad/tests/utils_testrepos.py 94.11% <0.00%> (+0.84%) ⬆️
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bpoldrack bpoldrack merged commit 2a33f7f into datalad:maint Oct 25, 2022
@yarikoptic-gitmate
Copy link
Collaborator

PR released in 0.17.9

@datalad datalad deleted a comment from yarikoptic-gitmate Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants