Improve datalad.support.tests.test_parallel.py::test_stalling - #7119
Merged
Conversation
This commit extends the time after which we believe to see a stalling thread to at least 5 seconds. This time will only be exhausted, if the thread is stalling, the duration of a passing test is usually in the range of a few dozen milliseconds. The commit adds output processing in order to actually start of few runner-related threads and perform thread-based asynchronous data processing. The huge time limit will hopefully reduce the number of false positives greatly, though is cannot *guarantee* the absence of false positives, it makes them unlikely, i.e. less than 1 false positive per 10e5 executions.
christian-monch
added
the
semver-tests
|
Code Climate has analyzed commit eded6ae and detected 5 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Codecov ReportBase: 89.37% // Head: 90.93% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## maint #7119 +/- ##
==========================================
+ Coverage 89.37% 90.93% +1.55%
==========================================
Files 355 355
Lines 46497 46498 +1
Branches 6327 6327
==========================================
+ Hits 41558 42283 +725
+ Misses 4924 4200 -724
Partials 15 15
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Member
|
Thank you @christian-monch ! |
Collaborator
|
PR released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends the time after which we believe to witness a stalling thread to at least 5 seconds. This time-span will only be exhausted if the test is failing, i.e. an executing worker is stalling (or very very slow). The duration of a passing test is usually in the range of a few dozen milliseconds.
The commit adds output processing in order to actually start of few runner-related threads and performs thread-based asynchronous data processing.
The large time limit will hopefully reduce the number of false positives greatly, though it cannot guarantee the absence of false positives, it just makes them unlikely, i.e. less than 1 false positive per 10e5 executions.