Fix RIA file URL reporting in exception handling #7123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Probing for the existence of a ria_layout_version file internally constructs a target_ri variable only used for reporting the path to the file. We noticed recently that this reporting was off, duplicating paths, e.g.: [INFO ] RIA store unavailable. -caused by- file:///tmp/myriastore/tmp/myriastore/ria-layout-version not found. -caused by- [Errno 2] No such file or directory: '/tmp/myriastore/ria-layout-version' This duplication should be fixed with this small change. It extracts the file name (ria_layout_version) and appends it to the ria store location, instead of appending the entire path to it.
adswa
added
semver-patch
github-actions
bot
removed
the
CHANGELOG-missing
Codecov ReportBase: 89.39% // Head: 90.95% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## maint #7123 +/- ##
==========================================
+ Coverage 89.39% 90.95% +1.55%
==========================================
Files 355 355
Lines 46498 46498
Branches 6327 6327
==========================================
+ Hits 41569 42294 +725
+ Misses 4914 4189 -725
Partials 15 15
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Thx much, @adswa |
bpoldrack
approved these changes
Oct 28, 2022
|
PR released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probing for the existence of a ria_layout_version file internally misconstructs a
target_rivariable only used for reporting the path to the file. We noticed recently that this reporting was off, duplicating paths, e.g.:This duplication should be fixed with this small change. It extracts the file name (
ria_layout_version) and appends it to the ria store location, instead of appending the entire path to it.