Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XFAIL a check on length of results in test_gracefull_death #7126

Merged
merged 2 commits into from
Nov 1, 2022

Conversation

yarikoptic
Copy link
Member

Still happens in some busy environments, like recently within https://app.travis-ci.com/github/datalad/datalad/jobs/586725682 of #7118

Attn @bpoldrack who was after all the flaky tests

@yarikoptic yarikoptic added semver-tests Changes only affect tests, no impact on version CHANGELOG-missing When a PR's description does not contain a changelog item, yet. labels Oct 31, 2022
Copy link
Member

@bpoldrack bpoldrack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm kinda fine with this approach. Hence the approval.

However, I see little utility in having the test executed in the first place. Nobody was able/willing to figure it out while it was making CI fail, I predict nobody will care about an XFAIL either. So, whatever the outcome of the test - there will be no consequences. IMHO it's just wasted runtime.

@yarikoptic
Copy link
Member Author

Nobody was able/willing to figure it out while it was making CI fail

from my observation - busy system. And that was at large reason for majority of other fails in test_parallel -- consumer threads are not executed in the number/order expected by the test.

So, whatever the outcome of the test - there will be no consequences. IMHO it's just wasted runtime.

In general (not this particular xfail assert for which takes virtually no time) I agree to disagree: the test has other conditions and possibly even contributes uniquely to code coverage. As with any test, "they are useless" after possibly initial TDD is done and until some changes in environment or code make them resurface problems again. But I do agree that XFAILs are largely forgotten about, as well as our @known_failures.

Ok, overall, with this blessing let's proceed

@yarikoptic
Copy link
Member Author

note: travis - filed #7129 . appveyor -- seems like that new git/git-annex giving us issues we can no longer postpone looking at :-/ #7116

@yarikoptic yarikoptic merged commit dd63ef1 into datalad:maint Nov 1, 2022
@yarikoptic-gitmate
Copy link
Collaborator

PR released in 0.17.9

@datalad datalad deleted a comment from yarikoptic-gitmate Nov 7, 2022
@yarikoptic yarikoptic deleted the bf-xfail-graceful branch January 20, 2023 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-tests Changes only affect tests, no impact on version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants