Skip to content

BF(TST): allow for "file" protocol#7130

Merged
yarikoptic merged 3 commits intodatalad:maintfrom
yarikoptic:bf-git-2.38.1
Nov 2, 2022
Merged

BF(TST): allow for "file" protocol#7130
yarikoptic merged 3 commits intodatalad:maintfrom
yarikoptic:bf-git-2.38.1

Conversation

@yarikoptic
Copy link
Copy Markdown
Member

Similarly to git-annex disallowing it by default, now git started to disallow it for local clones. In our case it should be safe since we are cloning our own repos in the tests, thus should not be subject to the malicious attempts.

Closes #7116

Some runs in appveyor already carry new git so let's see if they all turn green now.

@yarikoptic
Copy link
Copy Markdown
Member Author

grr, CI isn't running at all, none of them! https://www.githubstatus.com/ is all green, hm...

Similarly to git-annex disallowing it by default, now git started to disallow
it for local clones. In our case it should be safe since we are cloning our own
repos in the tests, thus should not be subject to the malicious attempts.

Closes datalad#7116
@yarikoptic yarikoptic added CHANGELOG-missing When a PR's description does not contain a changelog item, yet. semver-tests Changes only affect tests, no impact on version labels Nov 1, 2022
@github-actions github-actions Bot removed the CHANGELOG-missing When a PR's description does not contain a changelog item, yet. label Nov 1, 2022
@yarikoptic
Copy link
Copy Markdown
Member Author

this is promising! restarted one run of appveyor which errorred out for unrelated reasons. If succeeds I would aim to merge no later than tomorrow and then prep merge into master. Please stop me or improve (feel free to commit improvements if needed)

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 1, 2022

Codecov Report

Base: 89.37% // Head: 90.95% // Increases project coverage by +1.58% 🎉

Coverage data is based on head (8f23977) compared to base (dd63ef1).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##            maint    #7130      +/-   ##
==========================================
+ Coverage   89.37%   90.95%   +1.58%     
==========================================
  Files         355      355              
  Lines       46502    46502              
  Branches     6327     6327              
==========================================
+ Hits        41561    42297     +736     
+ Misses       4926     4190     -736     
  Partials       15       15              
Impacted Files Coverage Δ
datalad/conftest.py 93.51% <ø> (ø)
datalad/_version.py 45.68% <0.00%> (ø)
datalad/support/tests/test_annexrepo.py 97.97% <0.00%> (+0.13%) ⬆️
datalad/support/tests/test_parallel.py 95.36% <0.00%> (+1.32%) ⬆️
datalad/support/tests/test_sshrun.py 100.00% <0.00%> (+1.72%) ⬆️
datalad/metadata/extractors/tests/test_xmp.py 100.00% <0.00%> (+7.40%) ⬆️
datalad/metadata/extractors/tests/test_base.py 100.00% <0.00%> (+12.19%) ⬆️
datalad/__init__.py 98.00% <0.00%> (+16.00%) ⬆️
datalad/tests/utils.py 56.96% <0.00%> (+35.36%) ⬆️
datalad/tests/test_tests_utils.py 92.34% <0.00%> (+92.34%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Copy Markdown
Member

@bpoldrack bpoldrack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left suggestion for changelog. Otherwise agree. Thx, @yarikoptic!

Comment thread changelog.d/pr-7130.md Outdated
@yarikoptic yarikoptic mentioned this pull request Nov 2, 2022
6 tasks
Co-authored-by: Benjamin Poldrack <bpoldrack@users.noreply.github.com>
@yarikoptic yarikoptic merged commit a8b4ae9 into datalad:maint Nov 2, 2022
@yarikoptic-gitmate
Copy link
Copy Markdown
Collaborator

PR released in 0.17.9

@datalad datalad deleted a comment from yarikoptic-gitmate Nov 7, 2022
@yarikoptic yarikoptic deleted the bf-git-2.38.1 branch January 20, 2023 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver-tests Changes only affect tests, no impact on version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fresh failures in datalad/git-annex tests -- likely due to new git

3 participants