BF(TST): allow for "file" protocol#7130
Conversation
|
grr, CI isn't running at all, none of them! https://www.githubstatus.com/ is all green, hm... |
Similarly to git-annex disallowing it by default, now git started to disallow it for local clones. In our case it should be safe since we are cloning our own repos in the tests, thus should not be subject to the malicious attempts. Closes datalad#7116
51b6ba0 to
affab49
Compare
|
this is promising! restarted one run of appveyor which errorred out for unrelated reasons. If succeeds I would aim to merge no later than tomorrow and then prep merge into |
Codecov ReportBase: 89.37% // Head: 90.95% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## maint #7130 +/- ##
==========================================
+ Coverage 89.37% 90.95% +1.58%
==========================================
Files 355 355
Lines 46502 46502
Branches 6327 6327
==========================================
+ Hits 41561 42297 +736
+ Misses 4926 4190 -736
Partials 15 15
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
bpoldrack
left a comment
There was a problem hiding this comment.
Left suggestion for changelog. Otherwise agree. Thx, @yarikoptic!
Co-authored-by: Benjamin Poldrack <bpoldrack@users.noreply.github.com>
|
PR released in |
Similarly to git-annex disallowing it by default, now git started to disallow it for local clones. In our case it should be safe since we are cloning our own repos in the tests, thus should not be subject to the malicious attempts.
Closes #7116
Some runs in appveyor already carry new
gitso let's see if they all turn green now.