Skip to content

More informative AltConstraint error #7132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2022

Conversation

bpoldrack
Copy link
Member

Closes #7092

@bpoldrack bpoldrack added the semver-patch Increment the patch version when merged label Nov 2, 2022
@bpoldrack
Copy link
Member Author

crippledFS failure: https://github.com/datalad/datalad/actions/runs/3376700932/jobs/5604739627

This one is strange. Apart from the fact that I don't see even a remote relationship to change here (and it didn't happen in #7115), I'm also wondering how the test could ever pass on crippled FS before. It relies on checking out DEFAULT_BRANCH which shouldn't work that way on adjusted branches.
I'm missing something. ATM neither the fact that it didn't fail before nor the fact that it now starts to fail makes any sense to me.

@codeclimate
Copy link

codeclimate bot commented Nov 3, 2022

Code Climate has analyzed commit 9208cf8 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Base: 89.17% // Head: 90.81% // Increases project coverage by +1.64% 🎉

Coverage data is based on head (9208cf8) compared to base (b25dd03).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7132      +/-   ##
==========================================
+ Coverage   89.17%   90.81%   +1.64%     
==========================================
  Files         325      325              
  Lines       44095    44095              
  Branches     5853     5853              
==========================================
+ Hits        39321    40046     +725     
+ Misses       4759     4034     -725     
  Partials       15       15              
Impacted Files Coverage Δ
datalad/support/constraints.py 91.32% <100.00%> (ø)
datalad/_version.py 45.68% <0.00%> (+0.27%) ⬆️
datalad/__init__.py 98.00% <0.00%> (+16.00%) ⬆️
datalad/tests/utils.py 56.96% <0.00%> (+35.36%) ⬆️
datalad/tests/test_tests_utils.py 92.34% <0.00%> (+92.34%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bpoldrack bpoldrack marked this pull request as ready for review November 4, 2022 12:15
@bpoldrack
Copy link
Member Author

I think this is trivial. Since CI passes now, will go ahead and merge.

@bpoldrack bpoldrack merged commit 48db002 into datalad:master Nov 4, 2022
@yarikoptic-gitmate
Copy link
Collaborator

PR released in 0.18.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AltConstraint error could be more informative
2 participants