Let EnsureDataset handle Path instances - #7133
Merged
Merged
Conversation
bpoldrack
force-pushed
the
ds-constraint-accept-path
branch
from
November 2, 2022 10:49
2c58900 to
32822a2
Compare
bpoldrack
marked this pull request as ready for review
November 2, 2022 15:15
yarikoptic
approved these changes
Nov 2, 2022
yarikoptic
left a comment
yarikoptic
left a comment
Member
There was a problem hiding this comment.
Looks good to me. appveyor tests should pass if rebased
Previously this constraint allowed for strings only. Closes datalad#7069
bpoldrack
force-pushed
the
ds-constraint-accept-path
branch
from
November 3, 2022 09:24
32822a2 to
32645c9
Compare
|
Code Climate has analyzed commit 32645c9 and detected 0 issues on this pull request. View more on Code Climate. |
Codecov ReportBase: 87.75% // Head: 90.81% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #7133 +/- ##
==========================================
+ Coverage 87.75% 90.81% +3.06%
==========================================
Files 325 325
Lines 44074 44095 +21
Branches 0 5853 +5853
==========================================
+ Hits 38675 40046 +1371
+ Misses 5399 4034 -1365
- Partials 0 15 +15
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Collaborator
|
PR released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously this constraint allowed for strings only.
Closes #7069