Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let EnsureDataset handle Path instances #7133

Merged
merged 1 commit into from
Nov 3, 2022

Conversation

bpoldrack
Copy link
Member

Previously this constraint allowed for strings only.

Closes #7069

@bpoldrack bpoldrack force-pushed the ds-constraint-accept-path branch from 2c58900 to 32822a2 Compare November 2, 2022 10:49
@bpoldrack bpoldrack added the semver-internal Changes only affect the internal API label Nov 2, 2022
@bpoldrack bpoldrack marked this pull request as ready for review November 2, 2022 15:15
Copy link
Member

@yarikoptic yarikoptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. appveyor tests should pass if rebased

Previously this constraint allowed for strings only.

Closes datalad#7069
@bpoldrack bpoldrack force-pushed the ds-constraint-accept-path branch from 32822a2 to 32645c9 Compare November 3, 2022 09:24
@codeclimate
Copy link

codeclimate bot commented Nov 3, 2022

Code Climate has analyzed commit 32645c9 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Base: 87.75% // Head: 90.81% // Increases project coverage by +3.06% 🎉

Coverage data is based on head (32645c9) compared to base (8abe1d0).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7133      +/-   ##
==========================================
+ Coverage   87.75%   90.81%   +3.06%     
==========================================
  Files         325      325              
  Lines       44074    44095      +21     
  Branches        0     5853    +5853     
==========================================
+ Hits        38675    40046    +1371     
+ Misses       5399     4034    -1365     
- Partials        0       15      +15     
Impacted Files Coverage Δ
datalad/distribution/dataset.py 96.34% <100.00%> (ø)
datalad/distribution/tests/test_dataset.py 99.70% <100.00%> (ø)
datalad/customremotes/tests/test_datalad.py 95.34% <0.00%> (-2.28%) ⬇️
datalad/cli/common_args.py 100.00% <0.00%> (ø)
datalad/tests/test_dochelpers.py 100.00% <0.00%> (ø)
datalad/support/tests/test_network.py 100.00% <0.00%> (ø)
datalad/local/tests/test_add_readme.py 100.00% <0.00%> (ø)
datalad/customremotes/tests/test_archives.py 89.36% <0.00%> (+0.07%) ⬆️
datalad/distributed/create_sibling_ria.py 85.71% <0.00%> (+0.08%) ⬆️
datalad/tests/test_utils.py 97.45% <0.00%> (+0.13%) ⬆️
... and 71 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bpoldrack bpoldrack merged commit b25dd03 into datalad:master Nov 3, 2022
@bpoldrack bpoldrack deleted the ds-constraint-accept-path branch November 3, 2022 11:07
@yarikoptic-gitmate
Copy link
Collaborator

PR released in 0.18.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-internal Changes only affect the internal API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EnsureDataset cannot handle Path values
3 participants