-
Notifications
You must be signed in to change notification settings - Fork 110
TST: reenable two now-passing core test on Windows CI #7152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportBase: 89.42% // Head: 49.11% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #7152 +/- ##
===========================================
- Coverage 89.42% 49.11% -40.31%
===========================================
Files 358 325 -33
Lines 46553 44076 -2477
Branches 6322 0 -6322
===========================================
- Hits 41628 21648 -19980
- Misses 4910 22428 +17518
+ Partials 15 0 -15
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Tests disabled in #6353 seem to pass now on Appveyor:
|
Fixes datalad#6333. Trial and error confirmed that these previously failing tests now pass again on Appveyors Windows tests.
Code Climate has analyzed commit d2b0828 and detected 0 issues on this pull request. View more on Code Climate. |
Ignore type-check fail, @adswa - looking into that ATM. |
sure you don't want this goodness in |
Don't think this matters much. We don't currently know whether this would actually pass on |
PR released in |
two core tests were disabled a year ago on windows ci - I want to briefly check if they still fail. Fixes #6333.