Skip to content

TST: reenable two now-passing core test on Windows CI #7152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 9, 2022

Conversation

adswa
Copy link
Member

@adswa adswa commented Nov 8, 2022

two core tests were disabled a year ago on windows ci - I want to briefly check if they still fail. Fixes #6333.

@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Base: 89.42% // Head: 49.11% // Decreases project coverage by -40.30% ⚠️

Coverage data is based on head (5bd884b) compared to base (2346326).
Patch coverage: 57.67% of modified lines in pull request are covered.

❗ Current head 5bd884b differs from pull request most recent head d2b0828. Consider uploading reports for the commit d2b0828 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #7152       +/-   ##
===========================================
- Coverage   89.42%   49.11%   -40.31%     
===========================================
  Files         358      325       -33     
  Lines       46553    44076     -2477     
  Branches     6322        0     -6322     
===========================================
- Hits        41628    21648    -19980     
- Misses       4910    22428    +17518     
+ Partials       15        0       -15     
Impacted Files Coverage Δ
datalad/cli/interface.py 97.22% <ø> (-2.78%) ⬇️
datalad/cli/tests/test_main.py 0.00% <0.00%> (-95.43%) ⬇️
datalad/conftest.py 84.25% <ø> (-9.26%) ⬇️
datalad/consts.py 96.42% <ø> (-3.58%) ⬇️
datalad/core/distributed/tests/test_push.py 97.45% <ø> (-1.28%) ⬇️
datalad/core/local/create.py 98.59% <ø> (-0.71%) ⬇️
datalad/core/local/tests/test_resulthooks.py 100.00% <ø> (ø)
datalad/customremotes/archives.py 0.00% <0.00%> (-90.31%) ⬇️
datalad/distributed/create_sibling_ghlike.py 23.91% <0.00%> (-40.73%) ⬇️
datalad/distributed/create_sibling_gin.py 74.19% <ø> (-9.68%) ⬇️
... and 287 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@adswa
Copy link
Member Author

adswa commented Nov 8, 2022

Tests disabled in #6353 seem to pass now on Appveyor:

[...]
[gw1] PASSED ..\datalad\core\distributed\tests\test_push.py::test_ria_push
[...]
[gw1] PASSED ..\datalad\core\distributed\tests\test_push.py::test_nested_pushclone_cycle_allplatforms 

Fixes datalad#6333.
Trial and error confirmed that these previously failing tests now pass
again on Appveyors Windows tests.
@adswa adswa added the semver-tests Changes only affect tests, no impact on version label Nov 8, 2022
@adswa adswa changed the title TMP/WIP reenable two core test to check if win ci failures persists TST: reenable two core test to check if win ci failures persists Nov 8, 2022
@adswa adswa changed the title TST: reenable two core test to check if win ci failures persists TST: reenable two now-passing core test on Windows CI Nov 8, 2022
@codeclimate
Copy link

codeclimate bot commented Nov 8, 2022

Code Climate has analyzed commit d2b0828 and detected 0 issues on this pull request.

View more on Code Climate.

@bpoldrack
Copy link
Member

Ignore type-check fail, @adswa - looking into that ATM.

@yarikoptic
Copy link
Member

sure you don't want this goodness in maint? ;)

@bpoldrack
Copy link
Member

sure you don't want this goodness in maint? ;)

Don't think this matters much. We don't currently know whether this would actually pass on maint + I'm aiming for release from master by the end of the month anyway.

@bpoldrack bpoldrack merged commit b5f33db into datalad:master Nov 9, 2022
@adswa adswa deleted the tmp-wintst branch November 14, 2022 10:33
@yarikoptic-gitmate
Copy link
Collaborator

PR released in 0.18.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-tests Changes only affect tests, no impact on version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants