Skip to content

Fix ls import in benchmarks#7154

Merged
yarikoptic merged 1 commit into
datalad:maintfrom
bpoldrack:fix-benchmark
Nov 8, 2022
Merged

Fix ls import in benchmarks#7154
yarikoptic merged 1 commit into
datalad:maintfrom
bpoldrack:fix-benchmark

Conversation

@bpoldrack

Copy link
Copy Markdown
Member

ls command moved to datalad-deprecated. Import from api module, not from interface.

Closes #7149

ls command moved to datalad-deprecated. Import from api module, not from
interface.

Closes datalad#7149
@bpoldrack bpoldrack added the semver-internal Changes only affect the internal API label Nov 8, 2022
@bpoldrack
bpoldrack marked this pull request as ready for review November 8, 2022 09:46
@codecov

codecov Bot commented Nov 8, 2022

Copy link
Copy Markdown

Codecov Report

Base: 88.89% // Head: 90.92% // Increases project coverage by +2.02% 🎉

Coverage data is based on head (215fc75) compared to base (30a8ca2).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##            maint    #7154      +/-   ##
==========================================
+ Coverage   88.89%   90.92%   +2.02%     
==========================================
  Files         355      355              
  Lines       46516    46516              
  Branches     6329     6329              
==========================================
+ Hits        41351    42293     +942     
+ Misses       5150     4208     -942     
  Partials       15       15              
Impacted Files Coverage Δ
datalad/downloaders/base.py 81.97% <0.00%> (-0.69%) ⬇️
datalad/support/sshconnector.py 87.04% <0.00%> (-0.67%) ⬇️
datalad/_version.py 45.68% <0.00%> (ø)
datalad/__init__.py 98.00% <0.00%> (+16.00%) ⬆️
datalad/tests/utils.py 56.12% <0.00%> (+56.12%) ⬆️
datalad/tests/test_tests_utils.py 92.34% <0.00%> (+92.34%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yarikoptic

Copy link
Copy Markdown
Member

travis single error is that odd case of serve_http decorator erroring out... so let's proceed, thanks @bpoldrack !

@yarikoptic
yarikoptic merged commit 54770f9 into datalad:maint Nov 8, 2022
@yarikoptic-gitmate

Copy link
Copy Markdown
Collaborator

PR released in 0.17.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver-internal Changes only affect the internal API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Benchmarks started to error out

3 participants