Fix test failure with old annex#7159
Merged
Merged
Conversation
bpoldrack
added
semver-tests
github-actions
Bot
removed
the
CHANGELOG-missing
This test asserts that the push call will fail, because of read-only mode of the ORA remote. This is what happens, but with older annex we get an `IncompleteResultsError` rather than a `CommandError`. Not sure what changed for this to happen now, but in any case: `IncompleteResultsError` would be more desireable to begin with as we get an actual error result rather than a crash + if there's something to change to get this with all annex versions, it's in `push` or at a more generic layer when calling annex. The test, however, only is about testing that annex-copy and by extension datalad-push with the ORA remote fails under these circumstances. Hence, accept both ways of failing from within this test. The difference warrants an investigation of `push`/`Runner` or whatever is causing the difference here, though. Closes datalad#7157
Member
|
Great, thank you @bpoldrack ! |
Collaborator
|
PR released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test asserts that the push call will fail, because of read-only mode of the ORA remote. This is what happens, but with older annex we get an
IncompleteResultsErrorrather than aCommandError. Not sure what changed for this to happen now, but in any case:IncompleteResultsErrorwould be more desireable to begin with as we get an actual error result rather than a crash + if there's something to change to get this with all annex versions, it's inpushor at a more generic layer when calling annex. The test, however, only is about testing that annex-copy and by extension datalad-push with the ORA remote fails under these circumstances.Hence, accept both ways of failing from within this test. The difference warrants an investigation of
push/Runneror whatever is causing the difference here, though.Closes #7157