Skip to content

RF: Specify parameter choices uniformly #7161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 15, 2022
Merged

Conversation

bpoldrack
Copy link
Member

clean was an outlier in that regard.

Closes #7026

@bpoldrack bpoldrack added the semver-internal Changes only affect the internal API label Nov 9, 2022
@bpoldrack bpoldrack marked this pull request as ready for review November 9, 2022 13:04
`clean` was an outlier in that regard.

Closes datalad#7026
@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Base: 88.41% // Head: 90.95% // Increases project coverage by +2.54% 🎉

Coverage data is based on head (d93984b) compared to base (7bdb8a0).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##            maint    #7161      +/-   ##
==========================================
+ Coverage   88.41%   90.95%   +2.54%     
==========================================
  Files         355      355              
  Lines       46500    46700     +200     
  Branches     6328     6328              
==========================================
+ Hits        41113    42477    +1364     
+ Misses       5372     4208    -1164     
  Partials       15       15              
Impacted Files Coverage Δ
datalad/local/clean.py 88.57% <100.00%> (ø)
datalad/distribution/create_sibling.py 69.97% <0.00%> (-0.20%) ⬇️
datalad/_version.py 45.68% <0.00%> (ø)
datalad/cli/common_args.py 100.00% <0.00%> (ø)
datalad/tests/test_dochelpers.py 100.00% <0.00%> (ø)
datalad/support/tests/test_network.py 100.00% <0.00%> (ø)
datalad/support/tests/test_locking.py 95.87% <0.00%> (+0.04%) ⬆️
datalad/customremotes/tests/test_archives.py 89.36% <0.00%> (+0.07%) ⬆️
datalad/support/gitrepo.py 92.74% <0.00%> (+0.07%) ⬆️
datalad/distributed/create_sibling_ria.py 85.71% <0.00%> (+0.08%) ⬆️
... and 49 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@adswa
Copy link
Member

adswa commented Nov 15, 2022

I guess nobody complained in a week, merging.

@adswa adswa merged commit 19404cb into datalad:maint Nov 15, 2022
@yarikoptic-gitmate
Copy link
Collaborator

PR released in 0.17.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-internal Changes only affect the internal API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clean's parameter specification sticks out
3 participants