Remove with_testrepos from core package

[adswa]

Hopefully fixes #6752 and accompanies datalad/datalad-deprecated#80. It rips out the with_testrepos decorator and associated tests for it. I committed in very small chunks in hopes to easier fix what I might accidentally break with this when the CI runs; I plan to squash things together when this turns out to work.
🤞

The last commit cleans up a few imports and removes imports that seemed unused.

[codecov]

Codecov Report

Base: 88.56% // Head: 90.68% // Increases project coverage by +2.12% 🎉

Coverage data is based on head (938adf2) compared to base (5cdda33).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #7176      +/-   ##
==========================================
+ Coverage   88.56%   90.68%   +2.12%     
==========================================
  Files         325      324       -1     
  Lines       44144    43896     -248     
  Branches     5863     5835      -28     
==========================================
+ Hits        39095    39808     +713     
+ Misses       5034     4073     -961     
  Partials       15       15              

Impacted Files	Coverage Δ
datalad/conftest.py	93.39% <ø> (-0.25%)	⬇️
datalad/distribution/tests/test_siblings.py	100.00% <ø> (ø)
datalad/distribution/tests/test_update.py	99.82% <ø> (ø)
datalad/tests/test_tests_utils.py	92.89% <ø> (+92.89%)	⬆️
datalad/tests/test_tests_utils_pytest.py	99.14% <ø> (+0.23%)	⬆️
datalad/tests/utils.py	52.75% <ø> (+52.75%)	⬆️
datalad/tests/utils_testdatasets.py	100.00% <ø> (ø)
datalad/tests/utils_pytest.py	89.18% <100.00%> (-0.74%)	⬇️
datalad/distribution/utils.py	94.00% <0.00%> (-6.00%)	⬇️
datalad/distributed/create_sibling_gitea.py	59.45% <0.00%> (-1.07%)	⬇️
... and 55 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[bpoldrack]

Generally looks good to me.
However, considering the last time moving things to deprecated - could you temporarily commit a change in requirements, so that the two PRs (here and and in depreacted) are testing against each other rather than the released version of the other one, @adswa ?

Just git+http://github.com/datalad/datalad@branch in requirements-devel in datalad-deprecated and the same way of installing deprecated in the extension test workflow in here.

If those build turn out green, then I'm happy to remove the commit again and merge.

[adswa]

It took a bit of fiddling, but the two PRs testing against eachother pass. See here for deprecated: datalad/datalad-deprecated#80

I'll cancel the other tests (no need to waste that CO2 and wait for a sign of @bpoldrack to remove the temporary commit, and then I'll also squash the commits in here together.

[bpoldrack]

Thanks, @adswa! Please go ahead!

[qlty-cloud-legacy]

Code Climate has analyzed commit 938adf2 and detected 0 issues on this pull request.

View more on Code Climate.

[adswa]

In which order should this PR and the companion PR in deprecated be merged?

[bpoldrack]

@adswa:

In which order should this PR and the companion PR in deprecated be merged?

Ideally deprecated first (+release), since otherwise we'd introduce CI failures with the extension tests here into master, affecting every PR.

[adswa]

Ideally deprecated first (+release), since otherwise we'd introduce CI failures with the extension tests here into master, affecting every PR.

I left a general ping in the PR in deprecated asking for a second pair of eyes/review (wouldn't want to merge or release my own PR without others chiming in there)

[adswa]

DataLad deprecated now has with_testrepos and is released - merging.

[yarikoptic-gitmate]

PR released in 0.18.0