Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove with_testrepos from core package #7176

Merged
merged 5 commits into from
Nov 25, 2022
Merged

Conversation

adswa
Copy link
Member

@adswa adswa commented Nov 15, 2022

Hopefully fixes #6752 and accompanies datalad/datalad-deprecated#80. It rips out the with_testrepos decorator and associated tests for it. I committed in very small chunks in hopes to easier fix what I might accidentally break with this when the CI runs; I plan to squash things together when this turns out to work.
🤞

The last commit cleans up a few imports and removes imports that seemed unused.

@adswa adswa added the semver-tests Changes only affect tests, no impact on version label Nov 15, 2022
@codecov
Copy link

codecov bot commented Nov 15, 2022

Codecov Report

Base: 88.56% // Head: 90.68% // Increases project coverage by +2.12% 🎉

Coverage data is based on head (938adf2) compared to base (5cdda33).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7176      +/-   ##
==========================================
+ Coverage   88.56%   90.68%   +2.12%     
==========================================
  Files         325      324       -1     
  Lines       44144    43896     -248     
  Branches     5863     5835      -28     
==========================================
+ Hits        39095    39808     +713     
+ Misses       5034     4073     -961     
  Partials       15       15              
Impacted Files Coverage Δ
datalad/conftest.py 93.39% <ø> (-0.25%) ⬇️
datalad/distribution/tests/test_siblings.py 100.00% <ø> (ø)
datalad/distribution/tests/test_update.py 99.82% <ø> (ø)
datalad/tests/test_tests_utils.py 92.89% <ø> (+92.89%) ⬆️
datalad/tests/test_tests_utils_pytest.py 99.14% <ø> (+0.23%) ⬆️
datalad/tests/utils.py 52.75% <ø> (+52.75%) ⬆️
datalad/tests/utils_testdatasets.py 100.00% <ø> (ø)
datalad/tests/utils_pytest.py 89.18% <100.00%> (-0.74%) ⬇️
datalad/distribution/utils.py 94.00% <0.00%> (-6.00%) ⬇️
datalad/distributed/create_sibling_gitea.py 59.45% <0.00%> (-1.07%) ⬇️
... and 55 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@bpoldrack bpoldrack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me.
However, considering the last time moving things to deprecated - could you temporarily commit a change in requirements, so that the two PRs (here and and in depreacted) are testing against each other rather than the released version of the other one, @adswa ?

Just git+http://github.com/datalad/datalad@branch in requirements-devel in datalad-deprecated and the same way of installing deprecated in the extension test workflow in here.

If those build turn out green, then I'm happy to remove the commit again and merge.

@adswa
Copy link
Member Author

adswa commented Nov 21, 2022

It took a bit of fiddling, but the two PRs testing against eachother pass. See here for deprecated: datalad/datalad-deprecated#80

I'll cancel the other tests (no need to waste that CO2 and wait for a sign of @bpoldrack to remove the temporary commit, and then I'll also squash the commits in here together.

@bpoldrack
Copy link
Member

Thanks, @adswa! Please go ahead!

Even more with_testrepos tests

Remove more dedicated with_testrepos tests and testrepos-related helper

remove testrepos related config / check

MNT: Remove with_testrepos decorator and its assertion from testutil test
@codeclimate
Copy link

codeclimate bot commented Nov 22, 2022

Code Climate has analyzed commit 938adf2 and detected 0 issues on this pull request.

View more on Code Climate.

@adswa
Copy link
Member Author

adswa commented Nov 23, 2022

In which order should this PR and the companion PR in deprecated be merged?

@bpoldrack
Copy link
Member

@adswa:

In which order should this PR and the companion PR in deprecated be merged?

Ideally deprecated first (+release), since otherwise we'd introduce CI failures with the extension tests here into master, affecting every PR.

@adswa
Copy link
Member Author

adswa commented Nov 24, 2022

Ideally deprecated first (+release), since otherwise we'd introduce CI failures with the extension tests here into master, affecting every PR.

I left a general ping in the PR in deprecated asking for a second pair of eyes/review (wouldn't want to merge or release my own PR without others chiming in there)

@adswa
Copy link
Member Author

adswa commented Nov 25, 2022

DataLad deprecated now has with_testrepos and is released - merging.

@adswa adswa merged commit 22a4862 into datalad:master Nov 25, 2022
@adswa adswa deleted the testreposnomore branch November 25, 2022 11:00
@yarikoptic-gitmate
Copy link
Collaborator

PR released in 0.18.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-tests Changes only affect tests, no impact on version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants