Skip to content

Reenable now passing test_path_diff test on Windows #7194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 21, 2022

Conversation

yarikoptic
Copy link
Member

Closes #3725

It is #7191 but against maint since IMHO it is worth there

@yarikoptic yarikoptic added semver-tests Changes only affect tests, no impact on version CHANGELOG-missing When a PR's description does not contain a changelog item, yet. labels Nov 18, 2022
@github-actions github-actions bot removed the CHANGELOG-missing When a PR's description does not contain a changelog item, yet. label Nov 18, 2022
@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Base: 88.28% // Head: 90.92% // Increases project coverage by +2.63% 🎉

Coverage data is based on head (01765fe) compared to base (19404cb).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##            maint    #7194      +/-   ##
==========================================
+ Coverage   88.28%   90.92%   +2.63%     
==========================================
  Files         355      355              
  Lines       46524    46523       -1     
  Branches     6331     6331              
==========================================
+ Hits        41076    42300    +1224     
+ Misses       5433     4208    -1225     
  Partials       15       15              
Impacted Files Coverage Δ
datalad/core/local/tests/test_diff.py 99.53% <ø> (+2.30%) ⬆️
datalad/support/gitrepo.py 92.74% <0.00%> (+0.15%) ⬆️
datalad/distribution/tests/test_install.py 99.81% <0.00%> (+0.18%) ⬆️
datalad/support/tests/test_annexrepo.py 97.97% <0.00%> (+0.20%) ⬆️
datalad/distribution/create_sibling.py 69.97% <0.00%> (+0.28%) ⬆️
datalad/distribution/tests/test_dataset.py 99.70% <0.00%> (+0.29%) ⬆️
datalad/core/distributed/tests/test_clone.py 97.59% <0.00%> (+0.36%) ⬆️
datalad/support/network.py 90.17% <0.00%> (+0.43%) ⬆️
datalad/core/local/tests/test_save.py 98.05% <0.00%> (+0.48%) ⬆️
datalad/distributed/tests/test_ria_basics.py 98.20% <0.00%> (+0.51%) ⬆️
... and 45 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yarikoptic-gitmate
Copy link
Collaborator

PR released in 0.17.10

@yarikoptic yarikoptic deleted the maint-windiff branch February 13, 2025 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-tests Changes only affect tests, no impact on version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

diff reports annexed file to be in git
3 participants