DOC: Add design document on Tests and CI#7195
Merged
Merged
Conversation
adswa
added
documentation
Member
I think, that would be awesome! :) |
adswa
changed the title
Codecov ReportBase: 88.63% // Head: 52.29% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #7195 +/- ##
===========================================
- Coverage 88.63% 52.29% -36.34%
===========================================
Files 325 325
Lines 44109 43584 -525
Branches 5863 5863
===========================================
- Hits 39096 22793 -16303
- Misses 4998 20682 +15684
- Partials 15 109 +94
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
yarikoptic
reviewed
Nov 21, 2022
yarikoptic
left a comment
yarikoptic
left a comment
Member
There was a problem hiding this comment.
THANK YOU! Left some comments
adswa
added
the
CHANGELOG-missing
for better control/smaller likelihood to accidentally run a systemwide pytest or datalad installation Co-authored-by: Yaroslav Halchenko <debian@onerussian.com> Update CONTRIBUTING.md Co-authored-by: Yaroslav Halchenko <debian@onerussian.com> Update docs/source/design/testing.rst Co-authored-by: Yaroslav Halchenko <debian@onerussian.com> [skip ci]
github-actions
Bot
removed
the
CHANGELOG-missing
bpoldrack
reviewed
Nov 22, 2022
bpoldrack
reviewed
Nov 22, 2022
bpoldrack
reviewed
Nov 22, 2022
bpoldrack
reviewed
Nov 22, 2022
bpoldrack
reviewed
Nov 22, 2022
- improved descriptions of file layouts for tests - removed mention of nose-based utils Co-authored-by: Benjamin Poldrack <bpoldrack@users.noreply.github.com> Update docs/source/design/testing.rst Co-authored-by: Benjamin Poldrack <bpoldrack@users.noreply.github.com> Update docs/source/design/testing.rst Co-authored-by: Benjamin Poldrack <bpoldrack@users.noreply.github.com> Update docs/source/design/testing.rst Co-authored-by: Benjamin Poldrack <bpoldrack@users.noreply.github.com> Update docs/source/design/testing.rst Co-authored-by: Benjamin Poldrack <bpoldrack@users.noreply.github.com> [skip ci]
|
Code Climate has analyzed commit ee8a311 and detected 0 issues on this pull request. View more on Code Climate. |
Member
|
Ok, let's go with this for now. Thank you @adswa! |
Collaborator
|
PR released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #6679 by moving the CONTRIBUTING section on migrating downstream code from nose to pytest into a dedicated Design document in the docs.
I just moved this section because there was an explicit issue about it, but if deemed useful, this new design document could contain more test-related information from contributing, and become a more general Design doc on tests and CI - what do you think?
[skip ci]