Skip to content

DOC: extend/fix CONTRIBUTING.md with information on testing, changelog and releasing#7204

Merged
bpoldrack merged 3 commits into
datalad:masterfrom
yarikoptic:docs
Nov 29, 2022
Merged

DOC: extend/fix CONTRIBUTING.md with information on testing, changelog and releasing#7204
bpoldrack merged 3 commits into
datalad:masterfrom
yarikoptic:docs

Conversation

@yarikoptic

Copy link
Copy Markdown
Member

It still had outdated information about using auto. Others were asking in matrix on the location of the build logs on smaug. So I listed those paths to ease locating them.

Ideally the PR should have been against maint which is now default visible branch but there were changes to CONTRIBUTING.md in master to refactor testing away, so to avoid merge conflicts etc, decided to keep it in master. Not that critical - eventually it would become maint ;-)

…g and releasing

It still had outdated information about using auto.
Others were asking in matrix on the location of the build
logs on smaug. So I listed those paths to ease locating
them
@yarikoptic yarikoptic added CHANGELOG-missing When a PR's description does not contain a changelog item, yet. semver-documentation Changes only affect the documentation, no impact on version labels Nov 28, 2022
@github-actions github-actions Bot removed the CHANGELOG-missing When a PR's description does not contain a changelog item, yet. label Nov 28, 2022
@codecov

codecov Bot commented Nov 28, 2022

Copy link
Copy Markdown

Codecov Report

Base: 88.67% // Head: 90.66% // Increases project coverage by +1.98% 🎉

Coverage data is based on head (1d4c4d9) compared to base (8ca0eab).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7204      +/-   ##
==========================================
+ Coverage   88.67%   90.66%   +1.98%     
==========================================
  Files         324      324              
  Lines       43912    43912              
  Branches     5842     5842              
==========================================
+ Hits        38941    39814     +873     
+ Misses       4956     4082     -874     
- Partials       15       16       +1     
Impacted Files Coverage Δ
datalad/interface/run_procedure.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/support/collections.py 84.37% <0.00%> (-9.38%) ⬇️
datalad/local/run_procedure.py 94.93% <0.00%> (-1.27%) ⬇️
datalad/_version.py 45.68% <0.00%> (+0.27%) ⬆️
datalad/__init__.py 98.00% <0.00%> (+16.00%) ⬆️
datalad/tests/utils.py 52.75% <0.00%> (+52.75%) ⬆️
datalad/tests/test_tests_utils.py 92.89% <0.00%> (+92.89%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@adswa adswa left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Comment thread changelog.d/pr-7204.md Outdated
@qlty-cloud-legacy

Copy link
Copy Markdown

Code Climate has analyzed commit 1d4c4d9 and detected 0 issues on this pull request.

View more on Code Climate.

@bpoldrack

Copy link
Copy Markdown
Member

Thank you, @yarikoptic

@yarikoptic-gitmate

Copy link
Copy Markdown
Collaborator

PR released in 0.18.0

@yarikoptic yarikoptic deleted the docs branch February 13, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver-documentation Changes only affect the documentation, no impact on version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants