DOC: extend/fix CONTRIBUTING.md with information on testing, changelog and releasing #7204
+25
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g and releasing It still had outdated information about using auto. Others were asking in matrix on the location of the build logs on smaug. So I listed those paths to ease locating them
yarikoptic
added
CHANGELOG-missing
github-actions
bot
removed
the
CHANGELOG-missing
Codecov ReportBase: 88.67% // Head: 90.66% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #7204 +/- ##
==========================================
+ Coverage 88.67% 90.66% +1.98%
==========================================
Files 324 324
Lines 43912 43912
Branches 5842 5842
==========================================
+ Hits 38941 39814 +873
+ Misses 4956 4082 -874
- Partials 15 16 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
yarikoptic
commented
Nov 28, 2022
|
Code Climate has analyzed commit 1d4c4d9 and detected 0 issues on this pull request. View more on Code Climate. |
|
Thank you, @yarikoptic |
|
PR released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It still had outdated information about using auto. Others were asking in matrix on the location of the build logs on smaug. So I listed those paths to ease locating them.
Ideally the PR should have been against
maintwhich is now default visible branch but there were changes to CONTRIBUTING.md in master to refactor testing away, so to avoid merge conflicts etc, decided to keep it in master. Not that critical - eventually it would becomemaint;-)