Let CLI report on exception causes #7210
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure the already existing
format_exception_with_cause
also works withtraceback.TracebackException
and use this to provide another format method forCapturedException
. This is then used with unexpectedly bubbled up exceptions by the CLI.Fixes #7163
FTR:
Actually hard to find a case where I know an exception would bubble up and actually have a
__cause__
in core.Making one up like this:
Would now be:
Whereas
Would lead to
Rational for sparing the class name when there's a message, is taken from the existing implementation used by special remotes: