Skip to content

Allow for brackets in PY&CMD doc markups#7226

Merged
yarikoptic merged 1 commit into
datalad:maintfrom
bpoldrack:fix-7225
Dec 14, 2022
Merged

Allow for brackets in PY&CMD doc markups#7226
yarikoptic merged 1 commit into
datalad:maintfrom
bpoldrack:fix-7225

Conversation

@bpoldrack
Copy link
Copy Markdown
Member

Fixes #7225

Interface specific substitutions did not work with nested brackets (and for some reason also not crossing newlines).

Looks like those regexes were simply meant to not be greedy.

Fixes datalad#7225

Interface specific substitutions did not work with nested brackets (and
for some reason also not crossing newlines).

Looks like those regexes were simply meant to not be greedy.
@bpoldrack bpoldrack added the semver-patch Increment the patch version when merged label Dec 14, 2022
@bpoldrack bpoldrack marked this pull request as ready for review December 14, 2022 11:27
@bpoldrack bpoldrack added the release Create a release when this pr is merged label Dec 14, 2022
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 14, 2022

Codecov Report

Base: 88.91% // Head: 90.94% // Increases project coverage by +2.02% 🎉

Coverage data is based on head (ad61af7) compared to base (9521431).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##            maint    #7226      +/-   ##
==========================================
+ Coverage   88.91%   90.94%   +2.02%     
==========================================
  Files         355      355              
  Lines       46695    46713      +18     
  Branches     6355     6355              
==========================================
+ Hits        41521    42483     +962     
+ Misses       5159     4215     -944     
  Partials       15       15              
Impacted Files Coverage Δ
datalad/cli/interface.py 100.00% <ø> (ø)
datalad/interface/base.py 95.36% <ø> (ø)
datalad/cli/tests/test_interface.py 100.00% <100.00%> (ø)
datalad/interface/tests/test_docs.py 100.00% <100.00%> (ø)
datalad/support/sshconnector.py 87.04% <0.00%> (-0.67%) ⬇️
datalad/_version.py 45.68% <0.00%> (ø)
datalad/__init__.py 98.00% <0.00%> (+16.00%) ⬆️
datalad/tests/utils.py 56.12% <0.00%> (+56.12%) ⬆️
datalad/tests/test_tests_utils.py 92.34% <0.00%> (+92.34%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yarikoptic yarikoptic merged commit 58ba516 into datalad:maint Dec 14, 2022
@yarikoptic-gitmate
Copy link
Copy Markdown
Collaborator

PR released in 0.17.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release Create a release when this pr is merged semver-patch Increment the patch version when merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dochelpers [PY: PY] macro handling cannot deal with [] in the conditional docs

3 participants