RF ORA#7235
Merged
Merged
Conversation
`clone` does an auto reconfiguration of ORA special remotes, if the dataset was cloned from a RIA store, an ORA remote failed to autoenable and clone finds that the special remote's uuid in the store it just cloned from. The clone URL would then be configured to be used by the ORA special remote. However, until now that new URL was passed to `annex enableremote` and thereby committed in the git-annex branch. This could lead to a back and forth of changing committed URLs by different users who may have access to that store via different methods (SSH/HTTP). This patch changes the reconfiguration to only happen locally in .git/config, since ORA does now respect and gives precedence to local configs.
Codecov ReportBase: 88.70% // Head: 88.79% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #7235 +/- ##
==========================================
+ Coverage 88.70% 88.79% +0.08%
==========================================
Files 325 326 +1
Lines 44124 44750 +626
Branches 5867 5887 +20
==========================================
+ Hits 39142 39734 +592
- Misses 4967 5001 +34
Partials 15 15
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This has long been overdue, since the special remote is called ORA for quite a while now.
This allows for datasets that were configured with the old ria special remote to still work and gives a message when such a special remote is enabled. Note, that there are further plans to use the spot for implementing a special remote that automatically migrates datasets.
|
Code Climate has analyzed commit 40d3430 and detected 6 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Member
Author
|
Ok, no objections raised and the setup failure for the "Test old nose code" build clearly is unrelated. |
Collaborator
|
PR released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a revival of #5859 (which I thought was long merged).
Apart from some refactoring in ORA, it introduces the possibility to override the special remote configs (in
git-annex:remote.log) by local configs. This is then used to change the reconfiguration of ORA remotes bycloneto only apply locally instead of committing a changed RIA URL (which could lead to a constant ping pong between different access methods to a RIA store).In addition, there is a shim special remote introduced here, that allows datasets using the old ria remote (https://github.com/datalad/git-annex-ria-remote) to still work. This doesn't come with a proper test, since there's little point in making the tests depend on a package that is deprecated and archived. Please note, that there are two more points about introducing this "second flavor" of the special remote:
initremote/enableremote.So, the point here is to introduce that second "spot".