Skip to content

DOC: fix EnsureCallable docstring#7245

Merged
yarikoptic merged 2 commits into
datalad:maintfrom
matrss:doc-fix-ensurecallable-docstring
Jan 6, 2023
Merged

DOC: fix EnsureCallable docstring#7245
yarikoptic merged 2 commits into
datalad:maintfrom
matrss:doc-fix-ensurecallable-docstring

Conversation

@matrss
Copy link
Copy Markdown
Contributor

@matrss matrss commented Jan 5, 2023

Just a small fix for a copy-paste mistake.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 5, 2023

Codecov Report

Base: 88.51% // Head: 88.51% // No change to project coverage 👍

Coverage data is based on head (98fb5ae) compared to base (98fb5ae).
Patch has no changes to coverable lines.

❗ Current head 98fb5ae differs from pull request most recent head 97e818d. Consider uploading reports for the commit 97e818d to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##            maint    #7245   +/-   ##
=======================================
  Coverage   88.51%   88.51%           
=======================================
  Files         326      326           
  Lines       44420    44420           
  Branches     5919     5919           
=======================================
  Hits        39318    39318           
  Misses       5087     5087           
  Partials       15       15           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yarikoptic yarikoptic added semver-documentation Changes only affect the documentation, no impact on version CHANGELOG-missing When a PR's description does not contain a changelog item, yet. labels Jan 6, 2023
@yarikoptic
Copy link
Copy Markdown
Member

Looks good to me but I think it better goes against maint branch.

@github-actions github-actions Bot removed the CHANGELOG-missing When a PR's description does not contain a changelog item, yet. label Jan 6, 2023
@qlty-cloud-legacy
Copy link
Copy Markdown

Code Climate has analyzed commit e5eded7 and detected 0 issues on this pull request.

View more on Code Climate.

@matrss matrss changed the base branch from master to maint January 6, 2023 15:28
@matrss matrss force-pushed the doc-fix-ensurecallable-docstring branch from e5eded7 to 97e818d Compare January 6, 2023 15:31
@matrss
Copy link
Copy Markdown
Contributor Author

matrss commented Jan 6, 2023

Makes sense. I changed the target branch to maint and rebased onto it.

@yarikoptic
Copy link
Copy Markdown
Member

Great, thank you!

@yarikoptic yarikoptic merged commit 9d3818f into datalad:maint Jan 6, 2023
@matrss matrss deleted the doc-fix-ensurecallable-docstring branch January 6, 2023 17:07
mih added a commit to datalad/datalad-next that referenced this pull request Jan 11, 2023
@yarikoptic-gitmate
Copy link
Copy Markdown
Collaborator

PR released in 0.18.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver-documentation Changes only affect the documentation, no impact on version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants