BF: Fix invalid version comparison - #7249
Conversation
Specifying 10.20221212+git18 as requirement doesn't work, when the reported version of an annex build is using a different scheme. It was used because the git-annex version required isn't released yet. See issue 7248. However, we know the scheme of annex versions (it's a date after the dot), therefore setting the required version to one day after the previous release does the trick with respect to released annex versions. Closes 7248
1711fa6 to
ed7caa5
Compare
Codecov ReportBase: 88.71% // Head: 88.71% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## maint #7249 +/- ##
=======================================
Coverage 88.71% 88.71%
=======================================
Files 326 326
Lines 44420 44420
Branches 5919 5919
=======================================
+ Hits 39407 39409 +2
+ Misses 4998 4996 -2
Partials 15 15
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
THANKS! I did feel that I will get us into trouble with that comparison but could not put finger to it... now I know and will try to remember. That comparison by "date based" version is what I thought to use instead too, so there we agree. |
|
travis stall -- filed and issue. let's proceed! Thanks @bpoldrack ! |
|
PR released in |
4 participants
Specifying 10.20221212+git18 as requirement doesn't work, when the reported version of an annex build is using a different scheme. It was used because the git-annex version required isn't released yet. See issue 7248.
However, we know the scheme of annex versions (it's a date after the dot), therefore setting the required version to one day after the previous release does the trick with respect to released annex versions. Hence, we will use this only with the coming release (not a current snapshot). But that is clearly more sensible than crashing on an annex version that doesn't support it yet.
Closes #7248