Skip to content

PERF: Buffer size optimization from datalad-next#7250

Merged
bpoldrack merged 1 commit into
datalad:maintfrom
bpoldrack:pull-buffer-patch
Jan 16, 2023
Merged

PERF: Buffer size optimization from datalad-next#7250
bpoldrack merged 1 commit into
datalad:maintfrom
bpoldrack:pull-buffer-patch

Conversation

@bpoldrack

@bpoldrack bpoldrack commented Jan 12, 2023

Copy link
Copy Markdown
Member

This is a trivial patch from datalad-next, that significantly improves performance of save,status, etc. b/c of a much too small buffer when the runner is reading output.

Closes #7190

@bpoldrack bpoldrack added the semver-patch Increment the patch version when merged label Jan 12, 2023
@yarikoptic

Copy link
Copy Markdown
Member

CI is red across the board, didn't look in detail but smth is "off".

@bpoldrack

Copy link
Copy Markdown
Member Author

Oops. Introduced a circular import consts <-> utils.

@bpoldrack bpoldrack added the release Create a release when this pr is merged label Jan 13, 2023
@codecov

codecov Bot commented Jan 13, 2023

Copy link
Copy Markdown

Codecov Report

Base: 88.71% // Head: 88.72% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (e889b0d) compared to base (9d3818f).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##            maint    #7250      +/-   ##
==========================================
+ Coverage   88.71%   88.72%   +0.01%     
==========================================
  Files         326      326              
  Lines       44420    44423       +3     
  Branches     5919     5919              
==========================================
+ Hits        39407    39415       +8     
+ Misses       4998     4993       -5     
  Partials       15       15              
Impacted Files Coverage Δ
datalad/runner/runnerthreads.py 97.50% <100.00%> (+0.02%) ⬆️
datalad/utils.py 87.97% <100.00%> (+0.02%) ⬆️
datalad/support/gitrepo.py 92.49% <0.00%> (-0.08%) ⬇️
datalad/_version.py 45.68% <0.00%> (ø)
datalad/tests/utils_pytest.py 89.18% <0.00%> (+0.10%) ⬆️
datalad/tests/test_utils.py 97.45% <0.00%> (+0.13%) ⬆️
datalad/distributed/ora_remote.py 79.80% <0.00%> (+0.27%) ⬆️
datalad/local/tests/test_add_archive_content.py 99.62% <0.00%> (+0.37%) ⬆️
datalad/support/tests/test_sshrun.py 100.00% <0.00%> (+1.72%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yarikoptic yarikoptic left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog needs tune

Comment thread changelog.d/pr-7250.md Outdated
This is a trivial patch from datalad-next, that significantly improves
performance of save,status, etc. b/c of a much too small buffer when
the runner is reading output.

Closes datalad#7190
@bpoldrack

Copy link
Copy Markdown
Member Author

Ok, fixed changelog, ubuntu's repos are available again and everything passed except for the "old nose code" action with fails during setup. This is #7259 and I'm going to ignore it for this PR. Merging.

@bpoldrack bpoldrack merged commit 5649c54 into datalad:maint Jan 16, 2023
@yarikoptic-gitmate

Copy link
Copy Markdown
Collaborator

PR released in 0.18.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release Create a release when this pr is merged semver-patch Increment the patch version when merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tune ThreadedRunner buffer size for better performance

3 participants