-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BF(TST): use older python 3.8 in testing nose utils #7260
Conversation
New one 3.10 causes installation problems since likely simply no longer maintained/compatible. For the sake of it, fix it to test against 3.8 and in another PR against master we should deprecate/remove nose parts entirely
Codecov ReportBase: 88.71% // Head: 90.70% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## maint #7260 +/- ##
==========================================
+ Coverage 88.71% 90.70% +1.98%
==========================================
Files 326 326
Lines 44420 44423 +3
Branches 5919 5919
==========================================
+ Hits 39406 40292 +886
+ Misses 4999 4116 -883
Partials 15 15
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
overall -- seems to be working, so I will merge since the only relevant "Test old nose code / test (pull_request) " passed and I just added the changelog snippet. |
PR released in |
New one 3.10 causes installation problems since likely simply no longer maintained/compatible. For the sake of it, fix it to test against 3.8 and in another PR against master we should deprecate/remove nose parts entirely
Closes #7259