Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF(TST): use older python 3.8 in testing nose utils #7260

Merged
merged 3 commits into from
Jan 16, 2023

Conversation

yarikoptic
Copy link
Member

New one 3.10 causes installation problems since likely simply no longer maintained/compatible. For the sake of it, fix it to test against 3.8 and in another PR against master we should deprecate/remove nose parts entirely

Closes #7259

New one 3.10 causes installation problems since likely simply
no longer maintained/compatible. For the sake of it, fix it
to test against 3.8 and in another PR against master we should
deprecate/remove nose parts entirely
@yarikoptic yarikoptic added semver-tests Changes only affect tests, no impact on version CHANGELOG-missing When a PR's description does not contain a changelog item, yet. labels Jan 16, 2023
@codecov
Copy link

codecov bot commented Jan 16, 2023

Codecov Report

Base: 88.71% // Head: 90.70% // Increases project coverage by +1.98% 🎉

Coverage data is based on head (944c768) compared to base (d3662eb).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 944c768 differs from pull request most recent head 29ab45e. Consider uploading reports for the commit 29ab45e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##            maint    #7260      +/-   ##
==========================================
+ Coverage   88.71%   90.70%   +1.98%     
==========================================
  Files         326      326              
  Lines       44420    44423       +3     
  Branches     5919     5919              
==========================================
+ Hits        39406    40292     +886     
+ Misses       4999     4116     -883     
  Partials       15       15              
Impacted Files Coverage Δ
datalad/runner/runnerthreads.py 97.50% <100.00%> (+0.02%) ⬆️
datalad/utils.py 87.97% <100.00%> (+0.02%) ⬆️
datalad/support/tests/test_sshrun.py 98.27% <0.00%> (-1.73%) ⬇️
datalad/local/tests/test_add_archive_content.py 99.25% <0.00%> (-0.38%) ⬇️
datalad/distributed/ora_remote.py 79.52% <0.00%> (-0.28%) ⬇️
datalad/tests/test_utils.py 97.32% <0.00%> (-0.14%) ⬇️
datalad/tests/utils_pytest.py 89.08% <0.00%> (-0.11%) ⬇️
datalad/support/gitrepo.py 92.49% <0.00%> (-0.08%) ⬇️
datalad/_version.py 45.68% <0.00%> (ø)
datalad/support/annexrepo.py 90.43% <0.00%> (+0.08%) ⬆️
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yarikoptic yarikoptic added CHANGELOG-missing When a PR's description does not contain a changelog item, yet. and removed CHANGELOG-missing When a PR's description does not contain a changelog item, yet. labels Jan 16, 2023
@github-actions github-actions bot removed the CHANGELOG-missing When a PR's description does not contain a changelog item, yet. label Jan 16, 2023
changelog.d/pr-7260.md Outdated Show resolved Hide resolved
@yarikoptic
Copy link
Member Author

overall -- seems to be working, so I will merge since the only relevant "Test old nose code / test (pull_request) " passed and I just added the changelog snippet.

@yarikoptic yarikoptic merged commit b23f3d1 into datalad:maint Jan 16, 2023
@yarikoptic yarikoptic deleted the bf-nose-testing branch January 20, 2023 23:28
@yarikoptic-gitmate
Copy link
Collaborator

PR released in 0.18.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-tests Changes only affect tests, no impact on version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nose tests action fails
2 participants