Skip to content

Remove nose-based testing utils and possibility to test extensions using nose #7261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 20, 2023

Conversation

yarikoptic
Copy link
Member

As promised in #7260 against maint.

@yarikoptic yarikoptic added semver-tests Changes only affect tests, no impact on version CHANGELOG-missing When a PR's description does not contain a changelog item, yet. labels Jan 16, 2023
@github-actions github-actions bot removed the CHANGELOG-missing When a PR's description does not contain a changelog item, yet. label Jan 16, 2023
@codeclimate
Copy link

codeclimate bot commented Jan 16, 2023

Code Climate has analyzed commit 1cddc14 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Jan 16, 2023

Codecov Report

Base: 88.72% // Head: 91.58% // Increases project coverage by +2.85% 🎉

Coverage data is based on head (1cddc14) compared to base (7afb741).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7261      +/-   ##
==========================================
+ Coverage   88.72%   91.58%   +2.85%     
==========================================
  Files         326      324       -2     
  Lines       44420    43033    -1387     
  Branches     5919     5771     -148     
==========================================
  Hits        39413    39413              
+ Misses       4991     3605    -1386     
+ Partials       16       15       -1     
Impacted Files Coverage Δ
datalad/conftest.py 91.58% <0.00%> (-1.87%) ⬇️
datalad/utils.py 87.94% <0.00%> (ø)
datalad/support/tests/test_sshconnector.py 100.00% <0.00%> (+1.22%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yarikoptic
Copy link
Member Author

thank you @adswa for approval, let's proceed and see if any remnants will be picked up by datalad-extensions testing ;)

@yarikoptic yarikoptic merged commit d39e3df into datalad:master Jan 20, 2023
@yarikoptic-gitmate
Copy link
Collaborator

PR released in 0.19.0

@yarikoptic yarikoptic deleted the rf-no-nose branch February 2, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-tests Changes only affect tests, no impact on version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants