-
Notifications
You must be signed in to change notification settings - Fork 110
Codespell more (CHANGELOGs etc) and remove custom CLI options from tox.ini #7271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…thin tox.ini invocation
Just melded multiple commits: [DATALAD RUNCMD] Fix one ambigous typo - beeing -> being === Do not change lines below === { "chain": [], "cmd": "git sedi beeing being", "exit": 0, "extra_inputs": [], "inputs": [], "outputs": [], "pwd": "." } ^^^ Do not change lines above ^^^ [DATALAD RUNCMD] Fix another ambigous typo === Do not change lines below === { "chain": [], "cmd": "git sedi 'ot too many files' 'of too many files'", "exit": 0, "extra_inputs": [], "inputs": [], "outputs": [], "pwd": "." } ^^^ Do not change lines above ^^^ anbother
=== Do not change lines below === { "chain": [], "cmd": "codespell -w", "exit": 0, "extra_inputs": [], "inputs": [], "outputs": [], "pwd": "." } ^^^ Do not change lines above ^^^
Codecov ReportBase: 88.73% // Head: 90.71% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## maint #7271 +/- ##
==========================================
+ Coverage 88.73% 90.71% +1.98%
==========================================
Files 326 326
Lines 44423 44423
Branches 5919 5919
==========================================
+ Hits 39419 40299 +880
+ Misses 4989 4109 -880
Partials 15 15
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
wow, noone got excited about reviewing typo fixes? ;) I skimmed again, seems good. Adding changelog and will merge tomorrow if no objections voiced. |
it was green before adding changelog and fails are "too code related" , just filed #7296 , will proceed as promised |
PR released in |
I was codespell'ing a few other projects and got scared that we do not codespell our own DataLad because there were no
.codespellrc
. apparently we did codespell but with custom CLI options in tox.ini and only the main package. This PR makes codespelling more thorough, and in particular with us using scriv for changelogs - makes more sense now since we can then spellcheck those entries too (I checked using strace that codespell does open files underchangelog.d/
).