Skip to content

Codespell more (CHANGELOGs etc) and remove custom CLI options from tox.ini #7271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 22, 2023

Conversation

yarikoptic
Copy link
Member

I was codespell'ing a few other projects and got scared that we do not codespell our own DataLad because there were no .codespellrc. apparently we did codespell but with custom CLI options in tox.ini and only the main package. This PR makes codespelling more thorough, and in particular with us using scriv for changelogs - makes more sense now since we can then spellcheck those entries too (I checked using strace that codespell does open files under changelog.d/).

Just melded multiple commits:

[DATALAD RUNCMD] Fix one ambigous typo - beeing -> being

=== Do not change lines below ===
{
 "chain": [],
 "cmd": "git sedi beeing being",
 "exit": 0,
 "extra_inputs": [],
 "inputs": [],
 "outputs": [],
 "pwd": "."
}
^^^ Do not change lines above ^^^

[DATALAD RUNCMD] Fix another ambigous typo

=== Do not change lines below ===
{
 "chain": [],
 "cmd": "git sedi 'ot too many files' 'of too many files'",
 "exit": 0,
 "extra_inputs": [],
 "inputs": [],
 "outputs": [],
 "pwd": "."
}
^^^ Do not change lines above ^^^

anbother
=== Do not change lines below ===
{
 "chain": [],
 "cmd": "codespell -w",
 "exit": 0,
 "extra_inputs": [],
 "inputs": [],
 "outputs": [],
 "pwd": "."
}
^^^ Do not change lines above ^^^
@yarikoptic yarikoptic added the semver-internal Changes only affect the internal API label Jan 28, 2023
@codecov
Copy link

codecov bot commented Jan 28, 2023

Codecov Report

Base: 88.73% // Head: 90.71% // Increases project coverage by +1.98% 🎉

Coverage data is based on head (a264136) compared to base (475de13).
Patch has no changes to coverable lines.

❗ Current head a264136 differs from pull request most recent head 2340b4c. Consider uploading reports for the commit 2340b4c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##            maint    #7271      +/-   ##
==========================================
+ Coverage   88.73%   90.71%   +1.98%     
==========================================
  Files         326      326              
  Lines       44423    44423              
  Branches     5919     5919              
==========================================
+ Hits        39419    40299     +880     
+ Misses       4989     4109     -880     
  Partials       15       15              
Impacted Files Coverage Δ
datalad/customremotes/ria_remote.py 55.55% <0.00%> (-11.12%) ⬇️
datalad/_version.py 45.68% <0.00%> (ø)
datalad/support/annexrepo.py 90.51% <0.00%> (+0.08%) ⬆️
datalad/__init__.py 98.00% <0.00%> (+16.00%) ⬆️
datalad/tests/utils.py 52.75% <0.00%> (+52.75%) ⬆️
datalad/tests/test_tests_utils.py 92.89% <0.00%> (+92.89%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yarikoptic yarikoptic added the CHANGELOG-missing When a PR's description does not contain a changelog item, yet. label Feb 21, 2023
@github-actions github-actions bot removed the CHANGELOG-missing When a PR's description does not contain a changelog item, yet. label Feb 21, 2023
@yarikoptic
Copy link
Member Author

wow, noone got excited about reviewing typo fixes? ;) I skimmed again, seems good. Adding changelog and will merge tomorrow if no objections voiced.

@yarikoptic
Copy link
Member Author

it was green before adding changelog and fails are "too code related" , just filed #7296 , will proceed as promised

@yarikoptic-gitmate
Copy link
Collaborator

PR released in 0.18.2

@yarikoptic yarikoptic deleted the enh-codespell branch February 2, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-internal Changes only affect the internal API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants