create-sibling: Use C.UTF-8 locale instead of C #7273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- supports special characters in filenames (like umlauts, etc.) - `ls` seems to fall back to predictable `C` locale if `LC_ALL` is set to an unknown locale, so this should be safe. - still: `create-sibling` currently fails silently if an umlaut is in the `--target-dir` and the remote `ls` doesn't handle it properly. follow-up on PR datalad#7265
Codecov ReportBase: 88.71% // Head: 90.71% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## maint #7273 +/- ##
==========================================
+ Coverage 88.71% 90.71% +1.99%
==========================================
Files 326 326
Lines 44427 44429 +2
Branches 5919 5919
==========================================
+ Hits 39414 40303 +889
+ Misses 4998 4111 -887
Partials 15 15
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
bpoldrack
added
semver-patch
|
Thanks, @nobodyinperson! I think this is fine. |
github-actions
bot
removed
the
CHANGELOG-missing
bpoldrack
reviewed
Feb 7, 2023
|
I wonder if this would not kick-back on systems/environments without UTF-8 support available somehow (may be some really minimalistic environment/filesystem) but I guess we will see. Thanks @nobodyinperson ! |
|
PR released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lsseems to fall back to predictableClocale ifLC_ALLis set to an unknown locale, so this should be safe.create-siblingcurrently fails silently if an umlaut is in the--target-dirand the remotelsdoesn't handle it properly.follow-up on PR #7265