BF: path from .gitmodules could not be used with source candidate template #7280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
template The `path` property was treated as a special case in `GitRepo.get_submodules_` presumably to not yield redundant information, because what is returned is a dict where the path is the key and the other properties from `.gitmodules` make up the value (another dict), prefixed with `gitmodule_`. However, actual usage from `get` via `subdatasets` suggests, that the easiest is to just yield this "redundant" record. Once as the reported property exactly like `url`, `datalad-id` and whatever else, and in addition let the path remain the key. Throughout that chain the latter gets possibly turned into an absolute path anyway (which is not what we want to report here - it's just for internal use). Closes datalad#7274
Codecov ReportBase: 88.72% // Head: 90.71% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## maint #7280 +/- ##
==========================================
+ Coverage 88.72% 90.71% +1.98%
==========================================
Files 326 326
Lines 44423 44431 +8
Branches 5919 5919
==========================================
+ Hits 39415 40305 +890
+ Misses 4993 4111 -882
Partials 15 15
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
yarikoptic
reviewed
Feb 25, 2023
| @@ -0,0 +1,7 @@ | |||
| ### 🐛 Bug Fixes | |||
|
|
|||
| - Fixed that the `get` command would fail, when subdataset source-candidate-templates where using the `path` property from `.gitmodules`. | |||
There was a problem hiding this comment.
since it fixes smth, could there be a unittest which would demonstrate the effect of having smth fixed?
There was a problem hiding this comment.
Not clear to me, @yarikoptic. Did you miss the change to test_get.py or do you consider this somehow insufficient?
|
PR released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
pathproperty was treated as a special case inGitRepo.get_submodules_presumably to not yield redundant information, because what is returned is a dict where the path is the key and the other properties from.gitmodulesmake up the value (another dict), prefixed withgitmodule_.However, actual usage from
getviasubdatasetssuggests, that the easiest is to just yield this "redundant" record. Once as the reported property exactly likeurl,datalad-idand whatever else, and in addition let the path remain the key. Throughout that chain the latter gets possibly turned into an absolute path anyway (which is not what we want to report here - it's just for internal use).Closes #7274