Skip to content

Type-annotate and fix datalad/support/strings.py#7318

Merged
yarikoptic merged 2 commits into
datalad:maintfrom
jwodder:type-strings
Mar 13, 2023
Merged

Type-annotate and fix datalad/support/strings.py#7318
yarikoptic merged 2 commits into
datalad:maintfrom
jwodder:type-strings

Conversation

@jwodder

@jwodder jwodder commented Mar 9, 2023

Copy link
Copy Markdown
Contributor

Part of #6884.

@jwodder jwodder added semver-internal Changes only affect the internal API CHANGELOG-missing When a PR's description does not contain a changelog item, yet. labels Mar 9, 2023
@github-actions github-actions Bot removed the CHANGELOG-missing When a PR's description does not contain a changelog item, yet. label Mar 9, 2023
@codecov

codecov Bot commented Mar 9, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage has no change and project coverage change: -78.77 ⚠️

Comparison is base (6c42103) 88.61% compared to head (e0acb7e) 9.84%.

Additional details and impacted files
@@            Coverage Diff             @@
##            maint   #7318       +/-   ##
==========================================
- Coverage   88.61%   9.84%   -78.77%     
==========================================
  Files         326     326               
  Lines       44441   43918      -523     
  Branches     5919       0     -5919     
==========================================
- Hits        39381    4325    -35056     
- Misses       5045   39593    +34548     
+ Partials       15       0       -15     
Impacted Files Coverage Δ
datalad/support/strings.py 0.00% <0.00%> (-86.96%) ⬇️
datalad/coreapi.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/cli/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/local/unlock.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/cli/interface.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/support/param.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/local/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/cli/common_args.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/support/digests.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/tests/test_misc.py 0.00% <0.00%> (-100.00%) ⬇️
... and 286 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yarikoptic

Copy link
Copy Markdown
Member

Filed #7230 for the appveyor failure -- not related.

@yarikoptic yarikoptic left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will merge monday unless there is reservartions

@yarikoptic yarikoptic merged commit acfeccc into datalad:maint Mar 13, 2023
@yarikoptic-gitmate

Copy link
Copy Markdown
Collaborator

PR released in 0.18.3

@jwodder jwodder deleted the type-strings branch May 12, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver-internal Changes only affect the internal API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants