Skip to content

Do not render (empty) WTF report on other records #7322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 15, 2023
Merged

Do not render (empty) WTF report on other records #7322

merged 2 commits into from
Mar 15, 2023

Conversation

yarikoptic
Copy link
Member

Otherwise we get

❯ python -c "import datalad.api as dl; out = dl.wtf(sections=['murkie'])"
# WTF
# WTF
Traceback (most recent call last):
...

@yarikoptic
BF+ENH(TST): do not render (empty) WTF report on other records + stre…
e739b05 
…ngthen the test for unavail section

Otherwise we get

	❯ python -c "import datalad.api as dl; out = dl.wtf(sections=['murkie'])"
	# WTF
	# WTF
	Traceback (most recent call last):
	...
@yarikoptic yarikoptic added the UX user experience label Mar 13, 2023
@yarikoptic yarikoptic mentioned this pull request Mar 13, 2023
Merged
2 tasks
@yarikoptic yarikoptic added CHANGELOG-missing When a PR's description does not contain a changelog item, yet. semver-patch Increment the patch version when merged labels Mar 13, 2023
@github-actions github-actions bot removed the CHANGELOG-missing When a PR's description does not contain a changelog item, yet. label Mar 13, 2023
@adswa
Copy link
Member

adswa commented Mar 15, 2023

The test_gin_cloning failures coincide with scheduled maintenance on Gin

@yarikoptic yarikoptic merged commit 06d6b55 into datalad:maint Mar 15, 2023
@yarikoptic-gitmate
Copy link
Collaborator

PR released in 0.18.3

@yarikoptic yarikoptic deleted the bf-wtf-report branch February 2, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adswa adswa adswa approved these changes

Assignees
No one assigned
Labels
semver-patch Increment the patch version when merged UX user experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yarikoptic @adswa @yarikoptic-gitmate