Remove reset() kludge for tqdm, add version requirement - #7330
Merged
Conversation
This fulfills the TODO from the comment added with the kludge in 79dbdf2. The kludge is removed, and minimal tqdm dependency in setup.py is set to 4.32.0 (released 2019-05-13) -- current Debian stable has v4.57.0.
Following previous commit (32e2cbf), tqdm dependency was set to v4.32.0, which allows to simplify its configuration by removing settings / workarounds relevant to old versions only.
|
Code Climate has analyzed commit 85f0b66 and detected 2 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
yarikoptic
approved these changes
Mar 16, 2023
Collaborator
|
PR released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following a todo that I stumbled upon in the progress bars code which said "Drop this and set a minimum tqdm version once Debian stable has v4.32.0", I removed a kludge for old tqdm versions and introduced a minimum tqdm version dependency, 4.32.0 (released 2019-05-13) -- current Debian stable has v4.57.0. This also allowed removing settings / workarounds relevant to old versions only. Since tqdm v4.32.0 is fairly old as of today, this change seems safe to do.