Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip or xfail some currently failing or stalling tests #7331

Merged
merged 5 commits into from
Mar 16, 2023

Conversation

yarikoptic
Copy link
Member

@yarikoptic yarikoptic commented Mar 15, 2023

since masks away possible other issues and makes it difficult to assess PRs. The issue is filed, @adswa even had a look already, hopefully gets resolved some time soon.

Ref: #7320

edit: added more tests to be "treated" in hopes to get CI green again

@yarikoptic yarikoptic added the DX developer experience label Mar 15, 2023
@yarikoptic yarikoptic added tests Add or improve existing tests CHANGELOG-missing When a PR's description does not contain a changelog item, yet. labels Mar 15, 2023
@yarikoptic yarikoptic changed the title TST: add on_appveyor indicator and announce test_sibling_enable_sameas xfailing on appveyor Skip or xfail some currently failing or stalling tests Mar 15, 2023
@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +1.71 🎉

Comparison is base (06d6b55) 88.69% compared to head (c176969) 90.41%.

Additional details and impacted files
@@            Coverage Diff             @@
##            maint    #7331      +/-   ##
==========================================
+ Coverage   88.69%   90.41%   +1.71%     
==========================================
  Files         327      327              
  Lines       44527    44533       +6     
  Branches     5910     5910              
==========================================
+ Hits        39495    40264     +769     
+ Misses       5017     4250     -767     
- Partials       15       19       +4     
Impacted Files Coverage Δ
datalad/core/distributed/tests/test_clone.py 98.43% <100.00%> (+<0.01%) ⬆️
datalad/distribution/tests/test_siblings.py 100.00% <100.00%> (ø)
datalad/support/tests/test_annexrepo.py 98.04% <100.00%> (ø)
datalad/tests/test_archives.py 91.97% <100.00%> (+0.05%) ⬆️
datalad/tests/utils_pytest.py 89.22% <100.00%> (+0.13%) ⬆️

... and 28 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yarikoptic
Copy link
Member Author

yikes -- travis got this odd _queue.Empty errorring out of many tests in 1 run, as happened once before in #7243 (comment) and on appveyor in #7088 . restarted that travis run.

@yarikoptic yarikoptic added semver-tests Changes only affect tests, no impact on version CHANGELOG-missing When a PR's description does not contain a changelog item, yet. and removed CHANGELOG-missing When a PR's description does not contain a changelog item, yet. labels Mar 16, 2023
@github-actions github-actions bot removed the CHANGELOG-missing When a PR's description does not contain a changelog item, yet. label Mar 16, 2023
@yarikoptic
Copy link
Member Author

@bpoldrack blessed it in matrix. So I will proceed with merge to please other PRs CIs

@yarikoptic yarikoptic merged commit df23bd7 into datalad:maint Mar 16, 2023
@yarikoptic-gitmate
Copy link
Collaborator

PR released in 0.18.3

@yarikoptic yarikoptic deleted the bf-testing branch November 27, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DX developer experience semver-tests Changes only affect tests, no impact on version tests Add or improve existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants